| Message ID | 20210208123122.956545-1-jackmanb@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] selftests/bpf: Add missing cleanup in atomic_bounds test | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 8 maintainers not CCed: shuah@kernel.org kafai@fb.com netdev@vger.kernel.org songliubraving@fb.com kpsingh@kernel.org john.fastabend@gmail.com linux-kselftest@vger.kernel.org andrii@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 6 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Sorry this is garbage, I edited one tree and then built/tested a different one. Please ignore, v2 incoming. On Mon, 8 Feb 2021 at 13:31, Brendan Jackman <jackmanb@google.com> wrote: > > Add missing skeleton destroy call. > > Reported-by: Yonghong Song <yhs@fb.com> > Fixes: 37086bfdc737 ("bpf: Propagate stack bounds to registers in atomics w/ BPF_FETCH") > Signed-off-by: Brendan Jackman <jackmanb@google.com> > --- > tools/testing/selftests/bpf/prog_tests/atomic_bounds.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c b/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c > index addf127068e4..290506fa1c38 100644 > --- a/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c > +++ b/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c > @@ -12,4 +12,6 @@ void test_atomic_bounds(void) > skel = atomic_bounds__open_and_load(); > if (CHECK(!skel, "skel_load", "couldn't load program\n")) > return; > + > + atomic_bounds__destroy() > } > > base-commit: 23a2d70c7a2f28eb1a8f6bc19d68d23968cad0ce > -- > 2.30.0.478.g8a0d178c01-goog >
diff --git a/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c b/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c index addf127068e4..290506fa1c38 100644 --- a/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c +++ b/tools/testing/selftests/bpf/prog_tests/atomic_bounds.c @@ -12,4 +12,6 @@ void test_atomic_bounds(void) skel = atomic_bounds__open_and_load(); if (CHECK(!skel, "skel_load", "couldn't load program\n")) return; + + atomic_bounds__destroy() }
Add missing skeleton destroy call. Reported-by: Yonghong Song <yhs@fb.com> Fixes: 37086bfdc737 ("bpf: Propagate stack bounds to registers in atomics w/ BPF_FETCH") Signed-off-by: Brendan Jackman <jackmanb@google.com> --- tools/testing/selftests/bpf/prog_tests/atomic_bounds.c | 2 ++ 1 file changed, 2 insertions(+) base-commit: 23a2d70c7a2f28eb1a8f6bc19d68d23968cad0ce