| Message ID | 20210212104814.21452-1-vfedorenko@novek.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 295f830e53f4838344c97e12ce69637e2128ca8d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RESEND,net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: linux-afs@lists.infradead.org lucien.xin@gmail.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 11 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Vadim Fedorenko <vfedorenko@novek.ru> wrote: > As udp_port_cfg struct changes its members with dependency on IPv6 > configuration, the code in rxrpc should also check for IPv6. > > Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> Looks reasonable. Acked-by: David Howells <dhowells@redhat.com>
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Feb 2021 13:48:14 +0300 you wrote: > As udp_port_cfg struct changes its members with dependency on IPv6 > configuration, the code in rxrpc should also check for IPv6. > > Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> > > [...] Here is the summary with links: - [RESEND,net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config https://git.kernel.org/netdev/net-next/c/295f830e53f4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c index 546fd237a649..a4111408ffd0 100644 --- a/net/rxrpc/local_object.c +++ b/net/rxrpc/local_object.c @@ -120,9 +120,11 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net) if (udp_conf.family == AF_INET) { udp_conf.local_ip = srx->transport.sin.sin_addr; udp_conf.local_udp_port = srx->transport.sin.sin_port; +#if IS_ENABLED(CONFIG_AF_RXRPC_IPV6) } else { udp_conf.local_ip6 = srx->transport.sin6.sin6_addr; udp_conf.local_udp_port = srx->transport.sin6.sin6_port; +#endif } ret = udp_sock_create(net, &udp_conf, &local->socket); if (ret < 0) {
As udp_port_cfg struct changes its members with dependency on IPv6 configuration, the code in rxrpc should also check for IPv6. Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> --- net/rxrpc/local_object.c | 2 ++ 1 file changed, 2 insertions(+)