| Message ID | 20210223131457.1378978-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a7c9c25a99bbdaff51da26b874d2faaa8fdd72b5 |
| Delegated to: | BPF |
| Headers | show |
| Series | [PATCHv2,bpf-next] bpf: remove blank line in bpf helper description | expand |
On Tue, 23 Feb 2021 21:14:57 +0800 Hangbin Liu <liuhangbin@gmail.com> wrote: > Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") added an > extra blank line in bpf helper description. This will make > bpf_helpers_doc.py stop building bpf_helper_defs.h immediately after > bpf_check_mtu, which will affect future add functions. > > Fixes: 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > v2: remove the blank line directly instead of adding a * > --- > include/uapi/linux/bpf.h | 1 - > tools/include/uapi/linux/bpf.h | 1 - > 2 files changed, 2 deletions(-) Acked-by: Jesper Dangaard Brouer <brouer@redhat.com> > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 4c24daa43bac..79c893310492 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -3850,7 +3850,6 @@ union bpf_attr { > * > * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags) > * Description > - > * Check ctx packet size against exceeding MTU of net device (based > * on *ifindex*). This helper will likely be used in combination > * with helpers that adjust/change the packet size. > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h > index 4c24daa43bac..79c893310492 100644 > --- a/tools/include/uapi/linux/bpf.h > +++ b/tools/include/uapi/linux/bpf.h > @@ -3850,7 +3850,6 @@ union bpf_attr { > * > * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags) > * Description > - > * Check ctx packet size against exceeding MTU of net device (based > * on *ifindex*). This helper will likely be used in combination > * with helpers that adjust/change the packet size.
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Tue, 23 Feb 2021 21:14:57 +0800 you wrote: > Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") added an > extra blank line in bpf helper description. This will make > bpf_helpers_doc.py stop building bpf_helper_defs.h immediately after > bpf_check_mtu, which will affect future add functions. > > Fixes: 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > [...] Here is the summary with links: - [PATCHv2,bpf-next] bpf: remove blank line in bpf helper description https://git.kernel.org/bpf/bpf/c/a7c9c25a99bb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 4c24daa43bac..79c893310492 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -3850,7 +3850,6 @@ union bpf_attr { * * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags) * Description - * Check ctx packet size against exceeding MTU of net device (based * on *ifindex*). This helper will likely be used in combination * with helpers that adjust/change the packet size. diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 4c24daa43bac..79c893310492 100644 --- a/tools/include/uapi/linux/bpf.h +++ b/tools/include/uapi/linux/bpf.h @@ -3850,7 +3850,6 @@ union bpf_attr { * * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags) * Description - * Check ctx packet size against exceeding MTU of net device (based * on *ifindex*). This helper will likely be used in combination * with helpers that adjust/change the packet size.
Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") added an extra blank line in bpf helper description. This will make bpf_helpers_doc.py stop building bpf_helper_defs.h immediately after bpf_check_mtu, which will affect future add functions. Fixes: 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- v2: remove the blank line directly instead of adding a * --- include/uapi/linux/bpf.h | 1 - tools/include/uapi/linux/bpf.h | 1 - 2 files changed, 2 deletions(-)