diff mbox series

[bpf-next] skmsg: add function doc for skb->_sk_redir

Message ID 20210301184805.8174-1-xiyou.wangcong@gmail.com (mailing list archive)
State Accepted
Commit 6ed6e1c761f6c8391af654facbbbf1748ae9f386
Delegated to: BPF
Headers show
Series [bpf-next] skmsg: add function doc for skb->_sk_redir | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for bpf-next
netdev/subject_prefix success Link
netdev/cc_maintainers warning 16 maintainers not CCed: elver@google.com kuba@kernel.org davem@davemloft.net yhs@fb.com jonathan.lemon@gmail.com willemb@google.com pablo@netfilter.org haokexin@gmail.com nogikh@google.com ast@kernel.org decui@microsoft.com kpsingh@kernel.org songliubraving@fb.com kafai@fb.com andrii@kernel.org alobakin@pm.me
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 8548 this patch: 8548
netdev/kdoc success Errors and warnings before: 1 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 8944 this patch: 8944
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Cong Wang March 1, 2021, 6:48 p.m. UTC 
From: Cong Wang <cong.wang@bytedance.com>

This should fix the following warning:

include/linux/skbuff.h:932: warning: Function parameter or member
'_sk_redir' not described in 'sk_buff'

Reported-by: Lorenz Bauer <lmb@cloudflare.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
---
 include/linux/skbuff.h | 1 +
 1 file changed, 1 insertion(+)

Comments

John Fastabend March 1, 2021, 6:54 p.m. UTC | #1 
Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
> 
> This should fix the following warning:
> 
> include/linux/skbuff.h:932: warning: Function parameter or member
> '_sk_redir' not described in 'sk_buff'
> 
> Reported-by: Lorenz Bauer <lmb@cloudflare.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Jakub Sitnicki <jakub@cloudflare.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
> ---
>  include/linux/skbuff.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index bd84f799c952..0503c917d773 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -656,6 +656,7 @@ typedef unsigned char *sk_buff_data_t;
>   *	@protocol: Packet protocol from driver
>   *	@destructor: Destruct function
>   *	@tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
> + *	@_sk_redir: socket redirection information for skmsg
>   *	@_nfct: Associated connection, if any (with nfctinfo bits)
>   *	@nf_bridge: Saved data about a bridged frame - see br_netfilter.c
>   *	@skb_iif: ifindex of device we arrived on
> -- 
> 2.25.1
> 

Acked-by: John Fastabend <john.fastabend@gmail.com>
Lorenz Bauer March 2, 2021, 9:44 a.m. UTC | #2 
On Mon, 1 Mar 2021 at 18:48, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> From: Cong Wang <cong.wang@bytedance.com>
>
> This should fix the following warning:
>
> include/linux/skbuff.h:932: warning: Function parameter or member
> '_sk_redir' not described in 'sk_buff'

Thanks!

Acked-by: Lorenz Bauer <lmb@cloudflare.com>
patchwork-bot+netdevbpf@kernel.org March 4, 2021, 3:40 p.m. UTC | #3 
Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon,  1 Mar 2021 10:48:05 -0800 you wrote:
> From: Cong Wang <cong.wang@bytedance.com>
> 
> This should fix the following warning:
> 
> include/linux/skbuff.h:932: warning: Function parameter or member
> '_sk_redir' not described in 'sk_buff'
> 
> [...]

Here is the summary with links:
  - [bpf-next] skmsg: add function doc for skb->_sk_redir
    https://git.kernel.org/bpf/bpf-next/c/6ed6e1c761f6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index bd84f799c952..0503c917d773 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -656,6 +656,7 @@  typedef unsigned char *sk_buff_data_t;
  *	@protocol: Packet protocol from driver
  *	@destructor: Destruct function
  *	@tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
+ *	@_sk_redir: socket redirection information for skmsg
  *	@_nfct: Associated connection, if any (with nfctinfo bits)
  *	@nf_bridge: Saved data about a bridged frame - see br_netfilter.c
  *	@skb_iif: ifindex of device we arrived on