diff mbox series

[-next] iwlwifi: mvm: fix old-style static const declaration

Message ID 20210304102245.274847-1-weiyongjun1@huawei.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series [-next] iwlwifi: mvm: fix old-style static const declaration | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Wei Yongjun March 4, 2021, 10:22 a.m. UTC 
From: Wei Yongjun <weiyongjun1@huawei.com>

GCC reports warning as follows:

drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
 'static' is not at beginning of declaration [-Wold-style-declaration]
   14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
      | ^~~~~

Move static to the beginning of declaration.

Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Coelho March 23, 2021, 8:02 a.m. UTC | #1 
On Thu, 2021-03-04 at 10:22 +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> GCC reports warning as follows:
> 
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
>  'static' is not at beginning of declaration [-Wold-style-declaration]
>    14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
>       | ^~~~~
> 
> Move static to the beginning of declaration.
> 
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---

Thanks, I applied this to our internal tree and it will reach the
mainline following our usual process.

--
Cheers,
Luca.
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 873919048143..4d5a99cbcc9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -11,7 +11,7 @@ 
  * DDR needs frequency in units of 16.666MHz, so provide FW with the
  * frequency values in the adjusted format.
  */
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
 	/* LPDDR4 */
 
 	/* frequency 3733MHz */