| Message ID | 20210311033323.191873-1-hoang.h.le@dektech.com.au (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 1980d37565061ab44bdc2f9e4da477d3b9752e81 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] tipc: convert dest node's address to network order | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: davem@davemloft.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Mar 2021 10:33:22 +0700 you wrote: > From: Hoang Le <hoang.h.le@dektech.com.au> > > (struct tipc_link_info)->dest is in network order (__be32), so we must > convert the value to network order before assigning. The problem detected > by sparse: > > net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types) > net/tipc/netlink_compat.c:699:24: expected restricted __be32 [usertype] dest > net/tipc/netlink_compat.c:699:24: got int > > [...] Here is the summary with links: - [net-next,1/2] tipc: convert dest node's address to network order https://git.kernel.org/netdev/net-next/c/1980d3756506 - [net-next,2/2] tipc: clean up warnings detected by sparse https://git.kernel.org/netdev/net-next/c/97bc84bbd4de You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 5a1ce64039f7..0749df80454d 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -696,7 +696,7 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg, if (err) return err; - link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]); + link_info.dest = htonl(nla_get_flag(link[TIPC_NLA_LINK_DEST])); link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP])); nla_strscpy(link_info.str, link[TIPC_NLA_LINK_NAME], TIPC_MAX_LINK_NAME);