| Message ID | 20210316133853.2376863-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: broadcom: BCM4908_ENET should not default to y, unconditionally | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: masahiroy@kernel.org rdunlap@infradead.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 2021-03-16 14:38, Geert Uytterhoeven wrote: > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, drop the automatic enabling of BCM4908_ENET. > > Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 > controller driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Feel free to change to "default y if ARCH_BCM4908" and > > To fix this, restrict the automatic enabling of BCM4908_ENET to > ARCH_BCM4908. > > if you think BCM4908 SoCs cannot be used without enabling this. Yes, please make it default y if ARCH_BCM4908 instead.
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig index f8a168b73307c03b..57bac60ba2b190d2 100644 --- a/drivers/net/ethernet/broadcom/Kconfig +++ b/drivers/net/ethernet/broadcom/Kconfig @@ -54,7 +54,6 @@ config B44_PCI config BCM4908_ENET tristate "Broadcom BCM4908 internal mac support" depends on ARCH_BCM4908 || COMPILE_TEST - default y help This driver supports Ethernet controller integrated into Broadcom BCM4908 family SoCs.
Merely enabling CONFIG_COMPILE_TEST should not enable additional code. To fix this, drop the automatic enabling of BCM4908_ENET. Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Feel free to change to "default y if ARCH_BCM4908" and To fix this, restrict the automatic enabling of BCM4908_ENET to ARCH_BCM4908. if you think BCM4908 SoCs cannot be used without enabling this. --- drivers/net/ethernet/broadcom/Kconfig | 1 - 1 file changed, 1 deletion(-)