| Message ID | 20210318160142.31801-1-johan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 269aa0301224dc001676322c0305b0d02c93b7bb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: cdc_ncm: drop redundant driver-data assignment | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: oliver@neukum.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 18 Mar 2021 17:01:42 +0100 you wrote: > The driver data for the data interface has already been set by > usb_driver_claim_interface() so drop the subsequent redundant > assignment. > > Note that this also avoids setting the driver data three times in case > of a combined interface. > > [...] Here is the summary with links: - [net-next] net: cdc_ncm: drop redundant driver-data assignment https://git.kernel.org/netdev/net-next/c/269aa0301224 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 8acf30115428..8ae565a801b5 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -920,7 +920,6 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_ goto error2; } - usb_set_intfdata(ctx->data, dev); usb_set_intfdata(ctx->control, dev); if (ctx->ether_desc) {
The driver data for the data interface has already been set by usb_driver_claim_interface() so drop the subsequent redundant assignment. Note that this also avoids setting the driver data three times in case of a combined interface. Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/net/usb/cdc_ncm.c | 1 - 1 file changed, 1 deletion(-)