| Message ID | 20210405025339.86176-1-nixiaoming@huawei.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/mlx5: fix kfree mismatch in indir_table.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Mon, Apr 05, 2021 at 10:53:39AM +0800, Xiaoming Ni wrote: > Memory allocated by kvzalloc() should be freed by kvfree(). > > Fixes: 34ca65352ddf2 ("net/mlx5: E-Switch, Indirect table infrastructur") > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com> > --- > .../net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Mon, 2021-04-05 at 07:56 +0300, Leon Romanovsky wrote: > On Mon, Apr 05, 2021 at 10:53:39AM +0800, Xiaoming Ni wrote: > > Memory allocated by kvzalloc() should be freed by kvfree(). > > > > Fixes: 34ca65352ddf2 ("net/mlx5: E-Switch, Indirect table > > infrastructur") > > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com> > > --- > > .../net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++- > > ---- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Applied to net-mlx5. Thanks, Saeed.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c index 6f6772bf61a2..3da7becc1069 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw, err_ethertype: kfree(rule); out: - kfree(rule_spec); + kvfree(rule_spec); return err; } @@ -328,7 +328,7 @@ static int mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw, e->recirc_cnt = 0; out: - kfree(in); + kvfree(in); return err; } @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw, spec = kvzalloc(sizeof(*spec), GFP_KERNEL); if (!spec) { - kfree(in); + kvfree(in); return -ENOMEM; } @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw, } err_out: - kfree(spec); - kfree(in); + kvfree(spec); + kvfree(in); return err; }
Memory allocated by kvzalloc() should be freed by kvfree(). Fixes: 34ca65352ddf2 ("net/mlx5: E-Switch, Indirect table infrastructur") Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com> --- .../net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)