| Message ID | 20210412215629.17865-1-iii@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next,v2] bpf: Generate BTF_KIND_FLOAT when linking vmlinux | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 10 maintainers not CCed: netdev@vger.kernel.org linux-kbuild@vger.kernel.org yhs@fb.com kpsingh@kernel.org masahiroy@kernel.org andrii@kernel.org kafai@fb.com john.fastabend@gmail.com songliubraving@fb.com michal.lkml@markovi.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
On Mon, 2021-04-12 at 23:56 +0200, Ilya Leoshkevich wrote: > pahole v1.21 supports the --btf_gen_floats flag, which makes it > generate the information about the floating-point types [1]. > > Adjust link-vmlinux.sh to pass this flag to pahole in case it's > supported, which is determined using a simple version check. > > [1] https://lore.kernel.org/dwarves/YHRiXNX1JUF2Az0A@kernel.org/ > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- > scripts/link-vmlinux.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index 3b261b0f74f0..392c7fb94d3e 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -227,8 +227,13 @@ gen_btf() > > vmlinux_link ${1} > > + local extra_paholeopt= > + if [ "${pahole_ver}" -ge "121" ]; then > + extra_paholeopt="${extra_paholeopt} --btf_gen_floats" > + fi > + > info "BTF" ${2} > - LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${1} > + LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J${extra_paholeopt} ${1} > > # Create ${2} which contains just .BTF section but no symbols. > Add > # SHF_ALLOC because .BTF will be part of the vmlinux image. -- > strip-all Sorry, I realized I forgot to add a changelog (it's trivial, but still). Posting it here: v1: https://lore.kernel.org/bpf/20210331014356.256212-1-iii@linux.ibm.com/ v1 -> v2: Use a version check instead of probing.
On Mon, Apr 12, 2021 at 2:56 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote: > > pahole v1.21 supports the --btf_gen_floats flag, which makes it > generate the information about the floating-point types [1]. > > Adjust link-vmlinux.sh to pass this flag to pahole in case it's > supported, which is determined using a simple version check. > > [1] https://lore.kernel.org/dwarves/YHRiXNX1JUF2Az0A@kernel.org/ > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- few nits below, but otherwise looks good: Acked-by: Andrii Nakryiko <andrii@kernel.org> > scripts/link-vmlinux.sh | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index 3b261b0f74f0..392c7fb94d3e 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -227,8 +227,13 @@ gen_btf() > > vmlinux_link ${1} > > + local extra_paholeopt= let's keep variables together, can you move it up to `local pahole_ver` above? btw, does it need `=`, or `local paholeopt` will just create it as an empty variable? > + if [ "${pahole_ver}" -ge "121" ]; then > + extra_paholeopt="${extra_paholeopt} --btf_gen_floats" > + fi > + > info "BTF" ${2} > - LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${1} > + LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J${extra_paholeopt} ${1} it looks weird that there is no space between -J and $extra_paholeopt, why complicating things? extra space isn't a big deal in command invocation, imo > > # Create ${2} which contains just .BTF section but no symbols. Add > # SHF_ALLOC because .BTF will be part of the vmlinux image. --strip-all > -- > 2.29.2 >
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index 3b261b0f74f0..392c7fb94d3e 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -227,8 +227,13 @@ gen_btf() vmlinux_link ${1} + local extra_paholeopt= + if [ "${pahole_ver}" -ge "121" ]; then + extra_paholeopt="${extra_paholeopt} --btf_gen_floats" + fi + info "BTF" ${2} - LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${1} + LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J${extra_paholeopt} ${1} # Create ${2} which contains just .BTF section but no symbols. Add # SHF_ALLOC because .BTF will be part of the vmlinux image. --strip-all
pahole v1.21 supports the --btf_gen_floats flag, which makes it generate the information about the floating-point types [1]. Adjust link-vmlinux.sh to pass this flag to pahole in case it's supported, which is determined using a simple version check. [1] https://lore.kernel.org/dwarves/YHRiXNX1JUF2Az0A@kernel.org/ Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> --- scripts/link-vmlinux.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)