[net-next,REPOST] hv_netvsc: Make netvsc/VF binding check both MAC and serial number

Commit Message

Dexuan Cui April 24, 2021, 1:12 a.m. UTC

Currently the netvsc/VF binding logic only checks the PCI serial number.

The Microsoft Azure Network Adapter (MANA) supports multiple net_device
interfaces (each such interface is called a "vPort", and has its unique
MAC address) which are backed by the same VF PCI device, so the binding
logic should check both the MAC address and the PCI serial number.

The change should not break any other existing VF drivers, because
Hyper-V NIC SR-IOV implementation requires the netvsc network
interface and the VF network interface have the same MAC address.

Co-developed-by: Haiyang Zhang <[e-mail]>
Signed-off-by: Haiyang Zhang <[e-mail]>
Co-developed-by: Shachar Raindel <[e-mail]>
Signed-off-by: Shachar Raindel <[e-mail]>
Acked-by: Stephen Hemminger <[e-mail]>
Signed-off-by: Dexuan Cui <[e-mail]>
---

This patch was posted on 4/16 as 
"[PATCH v8 net-next 1/2] hv_netvsc: Make netvsc/VF binding check both MAC and serial number".

The patchwork link says its State is "Accepted":
https://patchwork.kernel.org/project/netdevbpf/patch/[e-mail]/
but I don't see it in the latest net-next tree, so let me repost it.

BTW, the other patch has been in the net-next for 4 days:
"[PATCH v8 net-next 2/2] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)"


 drivers/net/hyperv/netvsc_drv.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Comments

[e-mail] April 26, 2021, 1:30 a.m. UTC | #1

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 23 Apr 2021 18:12:35 -0700 you wrote:
> Currently the netvsc/VF binding logic only checks the PCI serial number.
> 
> The Microsoft Azure Network Adapter (MANA) supports multiple net_device
> interfaces (each such interface is called a "vPort", and has its unique
> MAC address) which are backed by the same VF PCI device, so the binding
> logic should check both the MAC address and the PCI serial number.
> 
> [...]

Here is the summary with links:
  - [net-next,REPOST] hv_netvsc: Make netvsc/VF binding check both MAC and serial number
    https://git.kernel.org/netdev/net-next/c/64ff412ad41f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Patch

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 7349a70af083..f682a5572d84 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -2297,6 +2297,7 @@  static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev)
 {
 	struct device *parent = vf_netdev->dev.parent;
 	struct net_device_context *ndev_ctx;
+	struct net_device *ndev;
 	struct pci_dev *pdev;
 	u32 serial;
 
@@ -2319,8 +2320,17 @@  static struct net_device *get_netvsc_byslot(const struct net_device *vf_netdev)
 		if (!ndev_ctx->vf_alloc)
 			continue;
 
-		if (ndev_ctx->vf_serial == serial)
-			return hv_get_drvdata(ndev_ctx->device_ctx);
+		if (ndev_ctx->vf_serial != serial)
+			continue;
+
+		ndev = hv_get_drvdata(ndev_ctx->device_ctx);
+		if (ndev->addr_len != vf_netdev->addr_len ||
+		    memcmp(ndev->perm_addr, vf_netdev->perm_addr,
+			   ndev->addr_len) != 0)
+			continue;
+
+		return ndev;
+
 	}
 
 	netdev_notice(vf_netdev,