| Message ID | 20210526095747.22446-3-tariqt@nvidia.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | BOND TLS flags fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: alobakin@pm.me linmiaohe@huawei.com george.mccollister@gmail.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 6389 this patch: 6389 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 6454 this patch: 6454 |
| netdev/header_inline | success | Link |
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 1a5f0c51bc99..0061c5b988c1 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -239,7 +239,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start) * If upper/master device has these features disabled, they must be disabled * on all lower/slave devices as well. */ -#define NETIF_F_UPPER_DISABLES NETIF_F_LRO +#define NETIF_F_UPPER_DISABLES (NETIF_F_LRO | NETIF_F_HW_TLS_TX) /* changeable features with no special hardware requirements */ #define NETIF_F_SOFT_FEATURES (NETIF_F_GSO | NETIF_F_GRO)
In the control flow of the TLS device offload feature, the upper device gives a pointer to the target lower device. All struct tlsdev_ops are called directly against the lower device, bypassing the upper. This means, the upper device has very limited means of blocking/disabling the TLS device offload. Today, for instance, disabling TX checksum offload of the upper dev automatically disables the TX TLS device offload capability. However, this does not affect the lower device at all, and it keeps doing TLS device offload for all new connections. Here we fix this, by propagating the disablement of the TLS TX device offload features to all lower devices. Fixes: ae0b04b238e2 ("net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled") Signed-off-by: Tariq Toukan <tariqt@nvidia.com> --- include/linux/netdev_features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)