| Message ID | 20210602112011.44473-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a58224040f2df8381146e7cfba9d657d5683ded1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,1/2] nfc: mrvl: remove useless "continue" at end of loop | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: yashsri421@gmail.com kuba@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 15 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 2 Jun 2021 13:20:10 +0200 you wrote: > The "continue" statement at the end of a for loop does not have an > effect. Entire loop contents can be slightly simplified to increase > code readability. No functional change. > > Suggested-by: Joe Perches <joe@perches.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > [...] Here is the summary with links: - [v2,1/2] nfc: mrvl: remove useless "continue" at end of loop https://git.kernel.org/netdev/net-next/c/a58224040f2d - [v2,2/2] nfc: mrvl: reduce the scope of local variables https://git.kernel.org/netdev/net-next/c/2c95e6c7e558 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/nfc/nfcmrvl/usb.c b/drivers/nfc/nfcmrvl/usb.c index bcd563cb556c..6fec20abfd1e 100644 --- a/drivers/nfc/nfcmrvl/usb.c +++ b/drivers/nfc/nfcmrvl/usb.c @@ -319,13 +319,9 @@ static int nfcmrvl_probe(struct usb_interface *intf, if (!drv_data->bulk_tx_ep && usb_endpoint_is_bulk_out(ep_desc)) { drv_data->bulk_tx_ep = ep_desc; - continue; - } - - if (!drv_data->bulk_rx_ep && - usb_endpoint_is_bulk_in(ep_desc)) { + } else if (!drv_data->bulk_rx_ep && + usb_endpoint_is_bulk_in(ep_desc)) { drv_data->bulk_rx_ep = ep_desc; - continue; } }
The "continue" statement at the end of a for loop does not have an effect. Entire loop contents can be slightly simplified to increase code readability. No functional change. Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Changes since v1: 1. Make it if-else-if as Joe suggested. --- drivers/nfc/nfcmrvl/usb.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)