| Message ID | 20210615095651.GA7479@duo.ucw.cz (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | cxgb4: fix wrong shift. | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | warning | CHECK: From:/Signed-off-by: email comments mismatch: 'From: Pavel Machek <pavel@denx.de>' != 'Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>' |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, Jun 15, 2021 at 11:56:51AM +0200, Pavel Machek wrote: > While fixing coverity warning, commit > dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift > value. Fix that. > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > index 22c9ac922eba..6260b3bebd2b 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c > @@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f, > WORD_MASK, f->fs.nat_lip[3] | > f->fs.nat_lip[2] << 8 | > f->fs.nat_lip[1] << 16 | > - (u64)f->fs.nat_lip[0] << 25, 1); > + (u64)f->fs.nat_lip[0] << 24, 1); > } > } > > <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>
From: Pavel Machek <pavel@denx.de> Date: Tue, 15 Jun 2021 11:56:51 +0200 > While fixing coverity warning, commit > dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift > value. Fix that. > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> Please repost with an appropriate Fixes: tag, thank you.
On Tue 2021-06-15 11:22:42, David Miller wrote: > From: Pavel Machek <pavel@denx.de> > Date: Tue, 15 Jun 2021 11:56:51 +0200 > > > While fixing coverity warning, commit > > dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift > > value. Fix that. > > > > Signed-off-by: Pavel Machek (CIP) <pavel@denx.de> > > Please repost with an appropriate Fixes: tag, thank you. Done, you should have PATCHv2 in your inbox. Best regards, Pavel
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c index 22c9ac922eba..6260b3bebd2b 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c @@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f, WORD_MASK, f->fs.nat_lip[3] | f->fs.nat_lip[2] << 8 | f->fs.nat_lip[1] << 16 | - (u64)f->fs.nat_lip[0] << 25, 1); + (u64)f->fs.nat_lip[0] << 24, 1); } }
While fixing coverity warning, commit dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift value. Fix that. Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>