| Message ID | 20210615135554.29158-1-wanghai38@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] samples/bpf: Add missing option to xdp_fwd usage | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 13 of 13 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, 15 Jun 2021 21:55:54 +0800 Wang Hai <wanghai38@huawei.com> wrote: > xdp_fwd usage() is missing the introduction of the "-S" > and "-F" options, this patch adds it. > > Signed-off-by: Wang Hai <wanghai38@huawei.com> > --- > samples/bpf/xdp_fwd_user.c | 2 ++ > 1 file changed, 2 insertions(+) Fixes: d50ecc46d18f ("samples/bpf: Attach XDP programs in driver mode by default") LGTM but please add "Fixes:" tag next time, I think patchwork will pick this up via this reply. Acked-by: Jesper Dangaard Brouer <brouer@redhat.com> > diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c > index 74a4583d0d86..00061261a8da 100644 > --- a/samples/bpf/xdp_fwd_user.c > +++ b/samples/bpf/xdp_fwd_user.c > @@ -67,6 +67,8 @@ static void usage(const char *prog) > "usage: %s [OPTS] interface-list\n" > "\nOPTS:\n" > " -d detach program\n" > + " -S use skb-mode\n" > + " -F force loading prog\n" > " -D direct table lookups (skip fib rules)\n", > prog); > } -
diff --git a/samples/bpf/xdp_fwd_user.c b/samples/bpf/xdp_fwd_user.c index 74a4583d0d86..00061261a8da 100644 --- a/samples/bpf/xdp_fwd_user.c +++ b/samples/bpf/xdp_fwd_user.c @@ -67,6 +67,8 @@ static void usage(const char *prog) "usage: %s [OPTS] interface-list\n" "\nOPTS:\n" " -d detach program\n" + " -S use skb-mode\n" + " -F force loading prog\n" " -D direct table lookups (skip fib rules)\n", prog); }
xdp_fwd usage() is missing the introduction of the "-S" and "-F" options, this patch adds it. Signed-off-by: Wang Hai <wanghai38@huawei.com> --- samples/bpf/xdp_fwd_user.c | 2 ++ 1 file changed, 2 insertions(+)