| Message ID | 20210616183405.3715-1-oleksandr.mazur@plvision.eu (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] drivers: net: netdevsim: fix devlink_trap selftests failing | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | fail | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Wed, Jun 16, 2021 at 09:34:05PM +0300, Oleksandr Mazur wrote: You need to add a proper commit message here > Fixes: a7b3527a43fe ("drivers: net: netdevsim: add devlink trap_drop_counter_get implementation") > No blank line between Fixes and SoB > Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu> > --- > Test-results: > selftests: drivers/net/netdevsim: devlink_trap.sh > TEST: Initialization [ OK ] > TEST: Trap action [ OK ] > TEST: Trap metadata [ OK ] > TEST: Non-existing trap [ OK ] > TEST: Non-existing trap action [ OK ] > TEST: Trap statistics [ OK ] > TEST: Trap group action [ OK ] > TEST: Non-existing trap group [ OK ] > TEST: Trap group statistics [ OK ] > TEST: Trap policer [ OK ] > TEST: Trap policer binding [ OK ] > TEST: Port delete [ OK ] > TEST: Device delete [ OK ] This can be in the commit message > --- > drivers/net/netdevsim/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c > index d85521989753..aad5e3d4a2b6 100644 > --- a/drivers/net/netdevsim/dev.c > +++ b/drivers/net/netdevsim/dev.c > @@ -269,7 +269,7 @@ static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev) > err = PTR_ERR(nsim_dev->nodes_ddir); > goto err_out; > } > - debugfs_create_bool("fail_trap_counter_get", 0600, > + debugfs_create_bool("fail_trap_drop_counter_get", 0600, > nsim_dev->ddir, > &nsim_dev->fail_trap_counter_get); Please change the name of the variable to match the name of the corresponding debugfs file > nsim_udp_tunnels_debugfs_create(nsim_dev); > -- > 2.17.1 >
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c index d85521989753..aad5e3d4a2b6 100644 --- a/drivers/net/netdevsim/dev.c +++ b/drivers/net/netdevsim/dev.c @@ -269,7 +269,7 @@ static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev) err = PTR_ERR(nsim_dev->nodes_ddir); goto err_out; } - debugfs_create_bool("fail_trap_counter_get", 0600, + debugfs_create_bool("fail_trap_drop_counter_get", 0600, nsim_dev->ddir, &nsim_dev->fail_trap_counter_get); nsim_udp_tunnels_debugfs_create(nsim_dev);
Fixes: a7b3527a43fe ("drivers: net: netdevsim: add devlink trap_drop_counter_get implementation") Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu> --- Test-results: selftests: drivers/net/netdevsim: devlink_trap.sh TEST: Initialization [ OK ] TEST: Trap action [ OK ] TEST: Trap metadata [ OK ] TEST: Non-existing trap [ OK ] TEST: Non-existing trap action [ OK ] TEST: Trap statistics [ OK ] TEST: Trap group action [ OK ] TEST: Non-existing trap group [ OK ] TEST: Trap group statistics [ OK ] TEST: Trap policer [ OK ] TEST: Trap policer binding [ OK ] TEST: Port delete [ OK ] TEST: Device delete [ OK ] --- drivers/net/netdevsim/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)