| Message ID | 20210617051119.1153120-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b244163f2c45c12053cb0291c955f892e79ed8a9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 6/17/21 12:11 AM, Yang Yingliang wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. of_node_put() on it before exiting > this function. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Alex Elder <elder@linaro.org> > --- > drivers/net/ipa/ipa_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c > index 2243e3e5b7ea..f82130db32f6 100644 > --- a/drivers/net/ipa/ipa_main.c > +++ b/drivers/net/ipa/ipa_main.c > @@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev) > } > > ret = of_address_to_resource(node, 0, &res); > + of_node_put(node); > if (ret) { > dev_err(dev, "error %d getting \"memory-region\" resource\n", > ret); >
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 17 Jun 2021 13:11:19 +0800 you wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. of_node_put() on it before exiting > this function. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > > [...] Here is the summary with links: - [net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load() https://git.kernel.org/netdev/net-next/c/b244163f2c45 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index 2243e3e5b7ea..f82130db32f6 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev) } ret = of_address_to_resource(node, 0, &res); + of_node_put(node); if (ret) { dev_err(dev, "error %d getting \"memory-region\" resource\n", ret);
This node pointer is returned by of_parse_phandle() with refcount incremented in this function. of_node_put() on it before exiting this function. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ipa/ipa_main.c | 1 + 1 file changed, 1 insertion(+)