From patchwork Wed Sep 1 09:18:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12468801 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79938C43214 for ; Wed, 1 Sep 2021 09:19:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F7A460462 for ; Wed, 1 Sep 2021 09:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243522AbhIAJUM (ORCPT ); Wed, 1 Sep 2021 05:20:12 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:37111 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243506AbhIAJUG (ORCPT ); Wed, 1 Sep 2021 05:20:06 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 998DF580AF6; Wed, 1 Sep 2021 05:19:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 01 Sep 2021 05:19:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=P6Nu6aTsQPnD4 VDKF+yrkv+lZ72RVulC249s1d3SA1A=; b=fyiiFo9+hVDa0nlR+UU1Q3DTE7o7i IdR3OXR8nGCe5ZivF8enSkzSHWkoUO7vVCcvRroK1m1WrJTlb8vXD1m+bjm/FRBY RZHfUME7wCL4RezW5KXfv48BMTO4ZEYU09EaNLFtSuQbA10Ik28llF7FWrT4OM8o 09gHoJMNm0BeK0p7Rt1gEQw0FUEj5ZLbU8hjjJr9j63wrY3/oXDRvOEOepNXWz5s zaivaq2iGAu8tGhL3mxWn6eKElwQ3paytmzI1hZICdVgOAko1eH8hk9jY+nRjEwh N2TSl4v4jaRlvFMRVVZLPK1yK2r5Wd9x94Bt8pLFwvs/bpIqmfALh4oww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=P6Nu6aTsQPnD4VDKF+yrkv+lZ72RVulC249s1d3SA1A=; b=ZXAfJMQ0 5Muo/tu+Fn9xKwqE3QGA6DsKAVG+iNx5E+XIZOwchCSnRe2DK7zkqVislyRGENVH RRz6Jj1f28wI3eWr7k1yeWZDN3Mo/byZmz0/kPaxV0OxNYrzRSO2SiVAyYEK/+F5 guuNmCjEtAYH2CrDnQFhJMMl2Y0K9Bb6dpKEIt18HWQD0oS4PMU+XM0y9n/RPdTB nG1CmZitU2ETdQ3ly+WXN4MGItX2D3GMYjteTRVgY3uiGimTmdg73rc0a1s65qqh ceI6MF9S1yyIYnhJKAGOOH23BGAl7XJjjVGcIGdme8AHqaRoTztPXc0WZ9tLnVLA njS96idSgzqwWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvfedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvdekleevfeffkeejhfffueelteelfeduieefheduudfggffhhfffheevveeh hedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Sep 2021 05:19:08 -0400 (EDT) From: Maxime Ripard To: devicetree@vger.kernel.org, Rob Herring , Frank Rowand , Chen-Yu Tsai , Maxime Ripard , =?utf-8?q?Jernej_=C5=A0krabec?= Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, "David S. Miller" , Jakub Kicinski , Linus Walleij , netdev@vger.kernel.org, Rob Herring Subject: [PATCH v2 07/52] dt-bindings: bluetooth: broadcom: Fix clocks check Date: Wed, 1 Sep 2021 11:18:07 +0200 Message-Id: <20210901091852.479202-8-maxime@cerno.tech> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210901091852.479202-1-maxime@cerno.tech> References: <20210901091852.479202-1-maxime@cerno.tech> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The original binding was mentioning that valid values for the clocks and clock-names property were one or two clocks from extclk, txco and lpo, with extclk being deprecated in favor of txco. However, the current binding lists a valid array as extclk, txco and lpo, with either one or two items. While this looks similar, it actually enforces that all the device trees use either ["extclk"], or ["extclk", "txco"]. That doesn't make much sense, since the two clocks are said to be equivalent, with one superseeding the other. lpo is also not a valid clock anymore, and would be as the third clock of the list, while we could have only this clock in the previous binding (and in DTs). Let's rework the clock clause to allow to have either: - extclk, and mark it a deprecated - txco alone - lpo alone - txco, lpo While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device tree so it's not an issue in practice. Similarly, ["lpo", "txco"] is still considered invalid, but it's generally considered as a best practice to fix the order of clocks. Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Linus Walleij Cc: netdev@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard Reviewed-by: Linus Walleij --- .../bindings/net/broadcom-bluetooth.yaml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml index fbdc2083bec4..5aac094fd217 100644 --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml @@ -50,16 +50,29 @@ properties: by interrupts and "host-wakeup" interrupt-names clocks: + minItems: 1 maxItems: 2 description: 1 or 2 clocks as defined in clock-names below, in that order clock-names: description: Names of the 1 to 2 supplied clocks - items: + oneOf: + - const: extclk + deprecated: true + description: Deprecated in favor of txco + - const: txco + description: > + external reference clock (not a standalone crystal) + - const: lpo - - const: extclk + description: > + external low power 32.768 kHz clock + + - items: + - const: txco + - const: lpo vbat-supply: description: phandle to regulator supply for VBAT