| Message ID | 20210913121442.10189-1-smalin@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] qed: rdma - don't wait for resources under hw error recovery flow | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 2 blamed authors not CCed: michal.kalderon@cavium.com tomer.tayar@cavium.com; 3 maintainers not CCed: michal.kalderon@cavium.com GR-everest-linux-l2@marvell.com tomer.tayar@cavium.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 26 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, Sep 13, 2021 at 03:14:42PM +0300, Shai Malin wrote: > If the HW device is during recovery, the HW resources will never return, > hence we shouldn't wait for the CID (HW context ID) bitmaps to clear. > This fix speeds up the error recovery flow. > > Fixes: 64515dc899df ("qed: Add infrastructure for error detection and recovery") > Signed-off-by: Michal Kalderon <mkalderon@marvell.com> > Signed-off-by: Ariel Elior <aelior@marvell.com> > Signed-off-by: Shai Malin <smalin@marvell.com> > --- > drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 7 +++++++ > drivers/net/ethernet/qlogic/qed/qed_roce.c | 7 +++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c > index fc8b3e64f153..4967e383c31a 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c > @@ -1323,6 +1323,13 @@ static int qed_iwarp_wait_for_all_cids(struct qed_hwfn *p_hwfn) > int rc; > int i; > > + /* If the HW device is during recovery, all resources are immediately > + * reset without receiving a per-cid indication from HW. In this case > + * we don't expect the cid_map to be cleared. > + */ > + if (p_hwfn->cdev->recov_in_prog) > + return 0; How do you ensure that this doesn't race with recovery flow? > + > rc = qed_iwarp_wait_cid_map_cleared(p_hwfn, > &p_hwfn->p_rdma_info->tcp_cid_map); > if (rc) > diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c b/drivers/net/ethernet/qlogic/qed/qed_roce.c > index f16a157bb95a..aff5a2871b8f 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_roce.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c > @@ -71,6 +71,13 @@ void qed_roce_stop(struct qed_hwfn *p_hwfn) > struct qed_bmap *rcid_map = &p_hwfn->p_rdma_info->real_cid_map; > int wait_count = 0; > > + /* If the HW device is during recovery, all resources are immediately > + * reset without receiving a per-cid indication from HW. In this case > + * we don't expect the cid bitmap to be cleared. > + */ > + if (p_hwfn->cdev->recov_in_prog) > + return; > + > /* when destroying a_RoCE QP the control is returned to the user after > * the synchronous part. The asynchronous part may take a little longer. > * We delay for a short while if an async destroy QP is still expected. > -- > 2.22.0 >
diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c index fc8b3e64f153..4967e383c31a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c @@ -1323,6 +1323,13 @@ static int qed_iwarp_wait_for_all_cids(struct qed_hwfn *p_hwfn) int rc; int i; + /* If the HW device is during recovery, all resources are immediately + * reset without receiving a per-cid indication from HW. In this case + * we don't expect the cid_map to be cleared. + */ + if (p_hwfn->cdev->recov_in_prog) + return 0; + rc = qed_iwarp_wait_cid_map_cleared(p_hwfn, &p_hwfn->p_rdma_info->tcp_cid_map); if (rc) diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c b/drivers/net/ethernet/qlogic/qed/qed_roce.c index f16a157bb95a..aff5a2871b8f 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_roce.c +++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c @@ -71,6 +71,13 @@ void qed_roce_stop(struct qed_hwfn *p_hwfn) struct qed_bmap *rcid_map = &p_hwfn->p_rdma_info->real_cid_map; int wait_count = 0; + /* If the HW device is during recovery, all resources are immediately + * reset without receiving a per-cid indication from HW. In this case + * we don't expect the cid bitmap to be cleared. + */ + if (p_hwfn->cdev->recov_in_prog) + return; + /* when destroying a_RoCE QP the control is returned to the user after * the synchronous part. The asynchronous part may take a little longer. * We delay for a short while if an async destroy QP is still expected.
If the HW device is during recovery, the HW resources will never return, hence we shouldn't wait for the CID (HW context ID) bitmaps to clear. This fix speeds up the error recovery flow. Fixes: 64515dc899df ("qed: Add infrastructure for error detection and recovery") Signed-off-by: Michal Kalderon <mkalderon@marvell.com> Signed-off-by: Ariel Elior <aelior@marvell.com> Signed-off-by: Shai Malin <smalin@marvell.com> --- drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 7 +++++++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 7 +++++++ 2 files changed, 14 insertions(+)