diff mbox series

[net] net/mlx4_en: Don't allow aRFS for encapsulated packets

Message ID 20210923065145.27583-1-tariqt@nvidia.com (mailing list archive)
State Accepted
Commit fdbccea419dc782079ce5881d2705cc9e3881480
Delegated to: Netdev Maintainers
Headers show
Series [net] net/mlx4_en: Don't allow aRFS for encapsulated packets | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net
netdev/subject_prefix success Link
netdev/cc_maintainers fail 2 blamed authors not CCed: amirv@mellanox.com ogerlitz@mellanox.com; 3 maintainers not CCed: amirv@mellanox.com linux-rdma@vger.kernel.org ogerlitz@mellanox.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link

Commit Message

Tariq Toukan Sept. 23, 2021, 6:51 a.m. UTC
From: Aya Levin <ayal@nvidia.com>

Driver doesn't support aRFS for encapsulated packets, return early error
in such a case.

Fixes: 1eb8c695bda9 ("net/mlx4_en: Add accelerated RFS support")
Signed-off-by: Aya Levin <ayal@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 +++
 1 file changed, 3 insertions(+)

Hi,
Please queue to -stable.

Regards,
Tariq

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 23, 2021, 12:20 p.m. UTC | #1
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 23 Sep 2021 09:51:45 +0300 you wrote:
> From: Aya Levin <ayal@nvidia.com>
> 
> Driver doesn't support aRFS for encapsulated packets, return early error
> in such a case.
> 
> Fixes: 1eb8c695bda9 ("net/mlx4_en: Add accelerated RFS support")
> Signed-off-by: Aya Levin <ayal@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net] net/mlx4_en: Don't allow aRFS for encapsulated packets
    https://git.kernel.org/netdev/net/c/fdbccea419dc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 35154635ec3a..8af7f2827322 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -372,6 +372,9 @@  mlx4_en_filter_rfs(struct net_device *net_dev, const struct sk_buff *skb,
 	int nhoff = skb_network_offset(skb);
 	int ret = 0;
 
+	if (skb->encapsulation)
+		return -EPROTONOSUPPORT;
+
 	if (skb->protocol != htons(ETH_P_IP))
 		return -EPROTONOSUPPORT;