| Message ID | 20211004191527.1610759-4-sean.anderson@seco.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for Xilinx PCS | expand |
On Mon, Oct 04, 2021 at 03:15:14PM -0400, Sean Anderson wrote: > The string should be "tx_disable" to match the state enum. > > Signed-off-by: Sean Anderson <sean.anderson@seco.com> > --- > > drivers/net/phy/sfp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 34e90216bd2c..ab77a9f439ef 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -134,7 +134,7 @@ static const char * const sm_state_strings[] = { > [SFP_S_LINK_UP] = "link_up", > [SFP_S_TX_FAULT] = "tx_fault", > [SFP_S_REINIT] = "reinit", > - [SFP_S_TX_DISABLE] = "rx_disable", > + [SFP_S_TX_DISABLE] = "tx_disable", > }; Hi Sean This is a bug fix. Please separate it out and base it on net, not net-next. Fixes: 4005a7cb4f55 ("net: phy: sftp: print debug message with text, not numbers") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 34e90216bd2c..ab77a9f439ef 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -134,7 +134,7 @@ static const char * const sm_state_strings[] = { [SFP_S_LINK_UP] = "link_up", [SFP_S_TX_FAULT] = "tx_fault", [SFP_S_REINIT] = "reinit", - [SFP_S_TX_DISABLE] = "rx_disable", + [SFP_S_TX_DISABLE] = "tx_disable", }; static const char *sm_state_to_str(unsigned short sm_state)
The string should be "tx_disable" to match the state enum. Signed-off-by: Sean Anderson <sean.anderson@seco.com> --- drivers/net/phy/sfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)