| Message ID | 20211004215002.1647148-1-sean.anderson@seco.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 25a9da6641f1f66006e93ddbefee13a437efa8c0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: sfp: Fix typo in state machine debug string | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | No static functions without inline keyword in header files |
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 4 Oct 2021 17:50:02 -0400 you wrote: > The string should be "tx_disable" to match the state enum. > > Fixes: 4005a7cb4f55 ("net: phy: sftp: print debug message with text, not numbers") > Signed-off-by: Sean Anderson <sean.anderson@seco.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > This was first submitted as [1], but has been submitted separately, per > request. > > [...] Here is the summary with links: - [net] net: sfp: Fix typo in state machine debug string https://git.kernel.org/netdev/net/c/25a9da6641f1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 34e90216bd2c..ab77a9f439ef 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -134,7 +134,7 @@ static const char * const sm_state_strings[] = { [SFP_S_LINK_UP] = "link_up", [SFP_S_TX_FAULT] = "tx_fault", [SFP_S_REINIT] = "reinit", - [SFP_S_TX_DISABLE] = "rx_disable", + [SFP_S_TX_DISABLE] = "tx_disable", }; static const char *sm_state_to_str(unsigned short sm_state)
The string should be "tx_disable" to match the state enum. Fixes: 4005a7cb4f55 ("net: phy: sftp: print debug message with text, not numbers") Signed-off-by: Sean Anderson <sean.anderson@seco.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- This was first submitted as [1], but has been submitted separately, per request. [1] https://lore.kernel.org/netdev/YVtypfZJfivfDnu7@lunn.ch/T/#m0b62cbe7804eb8df8dc69944ec3824274ae1b0c1 drivers/net/phy/sfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)