| Message ID | 20211006180927.GA913456@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 149ef7b2f949627bf3f1381d6a976f136a1887f5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] net: mana: Use kcalloc() instead of kzalloc() | expand |
> From: Gustavo A. R. Silva <gustavoars@kernel.org> > Sent: Wednesday, October 6, 2021 11:09 AM > ... > Subject: [PATCH][next] net: mana: Use kcalloc() instead of kzalloc() The [next] should be [net-next], butI guess David can fix this for you :-) Reviewed-by: Dexuan Cui <decui@microsoft.com>
diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c index d5c485a6d284..7c7a5fb91f79 100644 --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c @@ -363,7 +363,7 @@ static int mana_hwc_create_cq(struct hw_channel_context *hwc, u16 q_depth, } hwc_cq->gdma_cq = cq; - comp_buf = kcalloc(q_depth, sizeof(struct gdma_comp), GFP_KERNEL); + comp_buf = kcalloc(q_depth, sizeof(*comp_buf), GFP_KERNEL); if (!comp_buf) { err = -ENOMEM; goto out; @@ -580,7 +580,7 @@ static int mana_hwc_test_channel(struct hw_channel_context *hwc, u16 q_depth, return err; } - ctx = kzalloc(q_depth * sizeof(struct hwc_caller_ctx), GFP_KERNEL); + ctx = kcalloc(q_depth, sizeof(*ctx), GFP_KERNEL); if (!ctx) return -ENOMEM;
Use 2-factor multiplication argument form kcalloc() instead of kzalloc(). Link: https://github.com/KSPP/linux/issues/162 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)