| Message ID | 20211130063947.7529-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/2,-net] natsemi: xtensa: allow writing to const dev_addr array | expand |
On Mon, Nov 29, 2021 at 10:39 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > Fix section mismatch warnings in xtsonic. The first one appears to be > bogus and after fixing the second one, the first one is gone. > > WARNING: modpost: vmlinux.o(.text+0x529adc): Section mismatch in reference from the function sonic_get_stats() to the function .init.text:set_reset_devices() > The function sonic_get_stats() references > the function __init set_reset_devices(). > This is often because sonic_get_stats lacks a __init > annotation or the annotation of set_reset_devices is wrong. > > WARNING: modpost: vmlinux.o(.text+0x529b3b): Section mismatch in reference from the function xtsonic_probe() to the function .init.text:sonic_probe1() > The function xtsonic_probe() references > the function __init sonic_probe1(). > This is often because xtsonic_probe lacks a __init > annotation or the annotation of sonic_probe1 is wrong. > > Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.") The original code had the __devinit attribute for the function xtsonic_probe, it then was dropped in change 6980cbe4a6db ("natsemi: remove __dev* attributes"). I'd say that this is the change that this patch fixes. > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > --- > drivers/net/ethernet/natsemi/xtsonic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Max Filippov <jcmvbkbc@gmail.com>
On Mon, 29 Nov 2021 22:39:47 -0800 Randy Dunlap wrote: > Fix section mismatch warnings in xtsonic. The first one appears to be > bogus and after fixing the second one, the first one is gone. > > WARNING: modpost: vmlinux.o(.text+0x529adc): Section mismatch in reference from the function sonic_get_stats() to the function .init.text:set_reset_devices() > The function sonic_get_stats() references > the function __init set_reset_devices(). > This is often because sonic_get_stats lacks a __init > annotation or the annotation of set_reset_devices is wrong. > > WARNING: modpost: vmlinux.o(.text+0x529b3b): Section mismatch in reference from the function xtsonic_probe() to the function .init.text:sonic_probe1() > The function xtsonic_probe() references > the function __init sonic_probe1(). > This is often because xtsonic_probe lacks a __init > annotation or the annotation of sonic_probe1 is wrong. > > Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> Applied this one to net and I'll take Max's patch for dev_addr to net-next. Thanks!
--- linux-next-20211129.orig/drivers/net/ethernet/natsemi/xtsonic.c +++ linux-next-20211129/drivers/net/ethernet/natsemi/xtsonic.c @@ -120,7 +120,7 @@ static const struct net_device_ops xtson .ndo_set_mac_address = eth_mac_addr, }; -static int __init sonic_probe1(struct net_device *dev) +static int sonic_probe1(struct net_device *dev) { unsigned int silicon_revision; struct sonic_local *lp = netdev_priv(dev);
Fix section mismatch warnings in xtsonic. The first one appears to be bogus and after fixing the second one, the first one is gone. WARNING: modpost: vmlinux.o(.text+0x529adc): Section mismatch in reference from the function sonic_get_stats() to the function .init.text:set_reset_devices() The function sonic_get_stats() references the function __init set_reset_devices(). This is often because sonic_get_stats lacks a __init annotation or the annotation of set_reset_devices is wrong. WARNING: modpost: vmlinux.o(.text+0x529b3b): Section mismatch in reference from the function xtsonic_probe() to the function .init.text:sonic_probe1() The function xtsonic_probe() references the function __init sonic_probe1(). This is often because xtsonic_probe lacks a __init annotation or the annotation of sonic_probe1 is wrong. Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: Finn Thain <fthain@telegraphics.com.au> Cc: Chris Zankel <chris@zankel.net> Cc: Max Filippov <jcmvbkbc@gmail.com> Cc: linux-xtensa@linux-xtensa.org Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> --- drivers/net/ethernet/natsemi/xtsonic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)