diff mbox series

net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM

Message ID 20211130110209.804536-1-dtcccc@linux.alibaba.com (mailing list archive)
State Accepted
Commit 8057cbb8335cf6d419866737504473833e1d128a
Delegated to: Netdev Maintainers
Headers show
Series net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM | expand

Checks

Context Check Description
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Tianchen Ding Nov. 30, 2021, 11:02 a.m. UTC
There's build error while CONFIG_REGMAP_MMIO is not set
and CONFIG_MDIO_MSCC_MIIM=m.

ERROR: modpost: "__devm_regmap_init_mmio_clk"
[drivers/net/mdio/mdio-mscc-miim.ko] undefined!

Add the depend of REGMAP_MMIO to fix it.

Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
---
 drivers/net/mdio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Nov. 30, 2021, 6:13 p.m. UTC | #1
On Tue, Nov 30, 2021 at 07:02:09PM +0800, Tianchen Ding wrote:
> There's build error while CONFIG_REGMAP_MMIO is not set
> and CONFIG_MDIO_MSCC_MIIM=m.
> 
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/net/mdio/mdio-mscc-miim.ko] undefined!
> 
> Add the depend of REGMAP_MMIO to fix it.
> 
> Fixes: a27a76282837 ("net: mdio: mscc-miim: convert to a regmap implementation")
> Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
patchwork-bot+netdevbpf@kernel.org Dec. 2, 2021, 3 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 30 Nov 2021 19:02:09 +0800 you wrote:
> There's build error while CONFIG_REGMAP_MMIO is not set
> and CONFIG_MDIO_MSCC_MIIM=m.
> 
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/net/mdio/mdio-mscc-miim.ko] undefined!
> 
> Add the depend of REGMAP_MMIO to fix it.
> 
> [...]

Here is the summary with links:
  - net: mdio: mscc-miim: Add depend of REGMAP_MMIO on MDIO_MSCC_MIIM
    https://git.kernel.org/netdev/net-next/c/8057cbb8335c

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
index 6da1fcb25847..bfa16826a6e1 100644
--- a/drivers/net/mdio/Kconfig
+++ b/drivers/net/mdio/Kconfig
@@ -141,7 +141,7 @@  config MDIO_MVUSB
 
 config MDIO_MSCC_MIIM
 	tristate "Microsemi MIIM interface support"
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && REGMAP_MMIO
 	select MDIO_DEVRES
 	help
 	  This driver supports the MIIM (MDIO) interface found in the network