| Message ID | 20211201145351.152208-1-horatiu.vultur@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a290cf692779ccce6dbb05398fad32d035bfd313 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: lan966x: Fix duplicate check in frame extraction | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 1 Dec 2021 15:53:51 +0100 you wrote: > The blamed commit generates the following smatch static checker warning: > > drivers/net/ethernet/microchip/lan966x/lan966x_main.c:515 lan966x_xtr_irq_handler() > warn: duplicate check 'sz < 0' (previous on line 502) > > This patch fixes this issue removing the duplicate check 'sz < 0' > > [...] Here is the summary with links: - [net-next] net: lan966x: Fix duplicate check in frame extraction https://git.kernel.org/netdev/net-next/c/a290cf692779 You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c index e9e4dca6542d..be5e2b3a7f43 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c @@ -512,11 +512,6 @@ static irqreturn_t lan966x_xtr_irq_handler(int irq, void *args) *buf = val; } - if (sz < 0) { - err = sz; - break; - } - skb->protocol = eth_type_trans(skb, dev); netif_rx_ni(skb);
The blamed commit generates the following smatch static checker warning: drivers/net/ethernet/microchip/lan966x/lan966x_main.c:515 lan966x_xtr_irq_handler() warn: duplicate check 'sz < 0' (previous on line 502) This patch fixes this issue removing the duplicate check 'sz < 0' Fixes: d28d6d2e37d10d ("net: lan966x: add port module support") Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 5 ----- 1 file changed, 5 deletions(-)