| Message ID | 20211213095413.99456-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 93d576f54e0f697c7b54f4ddd718e68ccc52c4f2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] mt76: remove variable set but not used | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 13 Dec 2021 17:54:13 +0800 you wrote: > The code that uses variable queued has been removed, > and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued" > didn't do anything, so all they should be removed as well. > > Eliminate the following clang warnings: > drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable > ‘queued’ set but not used. > > [...] Here is the summary with links: - [-next] mt76: remove variable set but not used https://git.kernel.org/netdev/net-next/c/93d576f54e0f You are awesome, thank you!
diff --git a/drivers/net/wireless/mediatek/mt76/debugfs.c b/drivers/net/wireless/mediatek/mt76/debugfs.c index b8bcf22a07fd..027d9ea17d04 100644 --- a/drivers/net/wireless/mediatek/mt76/debugfs.c +++ b/drivers/net/wireless/mediatek/mt76/debugfs.c @@ -74,13 +74,12 @@ EXPORT_SYMBOL_GPL(mt76_queues_read); static int mt76_rx_queues_read(struct seq_file *s, void *data) { struct mt76_dev *dev = dev_get_drvdata(s->private); - int i, queued; + int i; seq_puts(s, " queue | hw-queued | head | tail |\n"); mt76_for_each_q_rx(dev, i) { struct mt76_queue *q = &dev->q_rx[i]; - queued = mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued; seq_printf(s, " %9d | %9d | %9d | %9d |\n", i, q->queued, q->head, q->tail); }
The code that uses variable queued has been removed, and "mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued" didn't do anything, so all they should be removed as well. Eliminate the following clang warnings: drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable ‘queued’ set but not used. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 2d8be76c1674 ("mt76: debugfs: improve queue node readability") Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/wireless/mediatek/mt76/debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)