| Message ID | 20211221230538.2546315-1-jesse.brandeburg@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0092db5fac2284c1906072141b017eba6afe02c5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1] ice: trivial: fix odd indenting | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 21 Dec 2021 15:05:38 -0800 you wrote: > Fix an odd indent where some code was left indented, and causes smatch > to warn: > ice_log_pkg_init() warn: inconsistent indenting > > While here, for consistency, add a break after the default case. > > This commit has a Fixes: but we caught this while it was only in net-next. > > [...] Here is the summary with links: - [net-next,v1] ice: trivial: fix odd indenting https://git.kernel.org/netdev/net-next/c/0092db5fac22 You are awesome, thank you!
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 865f2231bb24..661b59456742 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -4123,13 +4123,14 @@ static void ice_log_pkg_init(struct ice_hw *hw, enum ice_ddp_state state) break; case ICE_DDP_PKG_LOAD_ERROR: dev_err(dev, "An error occurred on the device while loading the DDP package. The device will be reset.\n"); - /* poll for reset to complete */ - if (ice_check_reset(hw)) - dev_err(dev, "Error resetting device. Please reload the driver\n"); + /* poll for reset to complete */ + if (ice_check_reset(hw)) + dev_err(dev, "Error resetting device. Please reload the driver\n"); break; case ICE_DDP_PKG_ERR: default: dev_err(dev, "An unknown error occurred when loading the DDP package. Entering Safe Mode.\n"); + break; } }
Fix an odd indent where some code was left indented, and causes smatch to warn: ice_log_pkg_init() warn: inconsistent indenting While here, for consistency, add a break after the default case. This commit has a Fixes: but we caught this while it was only in net-next. Fixes: 247dd97d713c ("ice: Refactor status flow for DDP load") Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/ice/ice_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)