| Message ID | 20211224091208.32274-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] net: phy: micrel: use min() macro instead of doing it manually | expand |
On 24.12.2021 10:12, Yang Li wrote: > Fix following coccicheck warning: > ./drivers/net/phy/micrel.c:1482:12-13: WARNING opportunity for min() > Please always check whether a coccicheck warning makes sense, and don't create "fixes" mechanically w/o thinking. Here using min() doesn't make sense because it's not about a numerical operation. ret < 0 is equivalent to is_err(ret). > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/net/phy/micrel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index c6a97fcca0e6..dda426596445 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -1479,7 +1479,7 @@ static int ksz886x_cable_test_wait_for_completion(struct phy_device *phydev) > !(val & KSZ8081_LMD_ENABLE_TEST), > 30000, 100000, true); > > - return ret < 0 ? ret : 0; > + return min(ret, 0); > } > > static int ksz886x_cable_test_one_pair(struct phy_device *phydev, int pair)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index c6a97fcca0e6..dda426596445 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -1479,7 +1479,7 @@ static int ksz886x_cable_test_wait_for_completion(struct phy_device *phydev) !(val & KSZ8081_LMD_ENABLE_TEST), 30000, 100000, true); - return ret < 0 ? ret : 0; + return min(ret, 0); } static int ksz886x_cable_test_one_pair(struct phy_device *phydev, int pair)
Fix following coccicheck warning: ./drivers/net/phy/micrel.c:1482:12-13: WARNING opportunity for min() Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/phy/micrel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)