| Message ID | 20220118171909.4375-1-victor@mojatatu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 973bf8fdd12f0e70ea351c018e68edd377a836d1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: sched: Clarify error message when qdisc kind is unknown | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 18 Jan 2022 14:19:09 -0300 you wrote: > When adding a tc rule with a qdisc kind that is not supported or not > compiled into the kernel, the kernel emits the following error: "Error: > Specified qdisc not found.". Found via tdc testing when ETS qdisc was not > compiled in and it was not obvious right away what the message meant > without looking at the kernel code. > > Change the error message to be more explicit and say the qdisc kind is > unknown. > > [...] Here is the summary with links: - [net-next] net: sched: Clarify error message when qdisc kind is unknown https://git.kernel.org/netdev/net/c/973bf8fdd12f You are awesome, thank you!
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index c9c6f49f9c28..eedb2df7cc6e 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1204,7 +1204,7 @@ static struct Qdisc *qdisc_create(struct net_device *dev, err = -ENOENT; if (!ops) { - NL_SET_ERR_MSG(extack, "Specified qdisc not found"); + NL_SET_ERR_MSG(extack, "Specified qdisc kind is unknown"); goto err_out; }
When adding a tc rule with a qdisc kind that is not supported or not compiled into the kernel, the kernel emits the following error: "Error: Specified qdisc not found.". Found via tdc testing when ETS qdisc was not compiled in and it was not obvious right away what the message meant without looking at the kernel code. Change the error message to be more explicit and say the qdisc kind is unknown. Signed-off-by: Victor Nogueira <victor@mojatatu.com> --- net/sched/sch_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)