| Message ID | 20220124151146.376446-4-maximmi@nvidia.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF |
| Headers | show |
| Series | Bugfixes for syncookie BPF helpers | expand |
| Context | Check | Description |
|---|---|---|
| bpf/vmtest-bpf | success | VM_Test |
| bpf/vmtest-bpf-PR | success | PR summary |
| netdev/tree_selection | success | Clearly marked for bpf |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 27 this patch: 27 |
| netdev/cc_maintainers | success | CCed 13 of 13 maintainers |
| netdev/build_clang | success | Errors and warnings before: 22 this patch: 22 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 32 this patch: 32 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Maxim Mikityanskiy wrote: > When CONFIG_SYN_COOKIES is off, bpf_tcp_check_syncookie returns > ENOTSUPP. It's a non-standard and deprecated code. The related function > bpf_tcp_gen_syncookie and most of the other functions use EOPNOTSUPP if > some feature is not available. This patch changes ENOTSUPP to EOPNOTSUPP > in bpf_tcp_check_syncookie. > > Fixes: 399040847084 ("bpf: add helper to check for a valid SYN cookie") > Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com> > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> This came up in another thread? Or was it the same and we lost the context in the commit msg. Either way I don't think we should start one-off changing these user facing error codes. Its not the only spot we do this and its been this way for sometime. Is it causing a real problem? > --- > net/core/filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 780e635fb52a..2c9106704821 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -6814,7 +6814,7 @@ BPF_CALL_5(bpf_tcp_check_syncookie, struct sock *, sk, void *, iph, u32, iph_len > > return -ENOENT; > #else > - return -ENOTSUPP; > + return -EOPNOTSUPP; > #endif > } > > -- > 2.30.2 >
On 2022-01-25 09:06, John Fastabend wrote: > Maxim Mikityanskiy wrote: >> When CONFIG_SYN_COOKIES is off, bpf_tcp_check_syncookie returns >> ENOTSUPP. It's a non-standard and deprecated code. The related function >> bpf_tcp_gen_syncookie and most of the other functions use EOPNOTSUPP if >> some feature is not available. This patch changes ENOTSUPP to EOPNOTSUPP >> in bpf_tcp_check_syncookie. >> >> Fixes: 399040847084 ("bpf: add helper to check for a valid SYN cookie") >> Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com> >> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> > > This came up in another thread? Or was it the same and we lost the context > in the commit msg. Either way I don't think we should start one-off > changing these user facing error codes. Its not the only spot we do this > and its been this way for sometime. > > Is it causing a real problem? I'm not aware of anyone complaining about it. It's just a cleanup to use the proper error code, since ENOTSUPP is a non-standard one (used in NFS?), for example, strerror() returns "Unknown error 524" instead of "Operation not supported". Source: Documentation/dev-tools/checkpatch.rst: > ENOTSUPP is not a standard error code and should be avoided in new > patches. EOPNOTSUPP should be used instead. > > See: https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/ >> --- >> net/core/filter.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/core/filter.c b/net/core/filter.c >> index 780e635fb52a..2c9106704821 100644 >> --- a/net/core/filter.c >> +++ b/net/core/filter.c >> @@ -6814,7 +6814,7 @@ BPF_CALL_5(bpf_tcp_check_syncookie, struct sock *, sk, void *, iph, u32, iph_len >> >> return -ENOENT; >> #else >> - return -ENOTSUPP; >> + return -EOPNOTSUPP; >> #endif >> } >> >> -- >> 2.30.2 >>
Maxim Mikityanskiy wrote: > On 2022-01-25 09:06, John Fastabend wrote: > > Maxim Mikityanskiy wrote: > >> When CONFIG_SYN_COOKIES is off, bpf_tcp_check_syncookie returns > >> ENOTSUPP. It's a non-standard and deprecated code. The related function > >> bpf_tcp_gen_syncookie and most of the other functions use EOPNOTSUPP if > >> some feature is not available. This patch changes ENOTSUPP to EOPNOTSUPP > >> in bpf_tcp_check_syncookie. > >> > >> Fixes: 399040847084 ("bpf: add helper to check for a valid SYN cookie") > >> Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com> > >> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> > > > > This came up in another thread? Or was it the same and we lost the context > > in the commit msg. Either way I don't think we should start one-off > > changing these user facing error codes. Its not the only spot we do this > > and its been this way for sometime. > > > > Is it causing a real problem? > > I'm not aware of anyone complaining about it. It's just a cleanup to use > the proper error code, since ENOTSUPP is a non-standard one (used in > NFS?), for example, strerror() returns "Unknown error 524" instead of > "Operation not supported". > > Source: Documentation/dev-tools/checkpatch.rst: iirc we didn't change the other ones so I see no reason to change this. Its not great, but anything using it has already figured it out and it is user facing.
diff --git a/net/core/filter.c b/net/core/filter.c index 780e635fb52a..2c9106704821 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -6814,7 +6814,7 @@ BPF_CALL_5(bpf_tcp_check_syncookie, struct sock *, sk, void *, iph, u32, iph_len return -ENOENT; #else - return -ENOTSUPP; + return -EOPNOTSUPP; #endif }
When CONFIG_SYN_COOKIES is off, bpf_tcp_check_syncookie returns ENOTSUPP. It's a non-standard and deprecated code. The related function bpf_tcp_gen_syncookie and most of the other functions use EOPNOTSUPP if some feature is not available. This patch changes ENOTSUPP to EOPNOTSUPP in bpf_tcp_check_syncookie. Fixes: 399040847084 ("bpf: add helper to check for a valid SYN cookie") Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)