| Message ID | 20220128205915.3995760-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0a78117213c4bb85dfebf89b924226883597bc60 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | pull request: bluetooth 2022-01-28 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Pull request for net |
| netdev/build_32bit | success | Errors and warnings before: 42 this patch: 38 |
| netdev/build_clang | success | Errors and warnings before: 5 this patch: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 42 this patch: 38 |
On Fri, 28 Jan 2022 12:59:15 -0800 Luiz Augusto von Dentz wrote: > The following changes since commit 8aaaf2f3af2ae212428f4db1af34214225f5cec3: > > Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2022-01-09 17:00:17 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git tags/for-net-next-2022-01-28 > > for you to fetch changes up to 91cb4c19118a19470a9d7d6dbdf64763bbbadcde: > > Bluetooth: Increment management interface revision (2022-01-27 12:35:13 -0800) > > ---------------------------------------------------------------- > bluetooth-next pull request for net-next: > > - Add support for RTL8822C hci_ver 0x08 > - Add support for RTL8852AE part 0bda:2852 > - Fix WBS setting for Intel legacy ROM products > - Enable SCO over I2S ib mt7921s > - Increment management interface revision Thanks for fixing the warnings! :) I presume this is for the net-next given the name of your tree, but a lot of patches here have fixes tags. What's your methodology on separating fixes from new features? I think it may be worth adjusting the filter there and send more stuff earlier to Linus's tree. Especially fixes with the right mix of confidence and impact or pure device ID additions. To be clear - happy to pull this PR as is, I was meaning to ask about this for a while.
Hi Jakub, >> The following changes since commit 8aaaf2f3af2ae212428f4db1af34214225f5cec3: >> >> Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2022-01-09 17:00:17 -0800) >> >> are available in the Git repository at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git tags/for-net-next-2022-01-28 >> >> for you to fetch changes up to 91cb4c19118a19470a9d7d6dbdf64763bbbadcde: >> >> Bluetooth: Increment management interface revision (2022-01-27 12:35:13 -0800) >> >> ---------------------------------------------------------------- >> bluetooth-next pull request for net-next: >> >> - Add support for RTL8822C hci_ver 0x08 >> - Add support for RTL8852AE part 0bda:2852 >> - Fix WBS setting for Intel legacy ROM products >> - Enable SCO over I2S ib mt7921s >> - Increment management interface revision > > Thanks for fixing the warnings! :) > > I presume this is for the net-next given the name of your tree, but > a lot of patches here have fixes tags. What's your methodology on > separating fixes from new features? > > I think it may be worth adjusting the filter there and send more > stuff earlier to Linus's tree. Especially fixes with the right mix > of confidence and impact or pure device ID additions. > > To be clear - happy to pull this PR as is, I was meaning to ask about > this for a while. we started to add Fixes: tag whenever you can identify a faulty commit or can track down the original issue. This way we can later easily go back and check. It have to note that a lot of vendor trees cherrypick patches and this helps them picking the right ones. I reviewed the list of patches again, and frankly none of them are super critical to go to Linus right away. So if you don’t mind, please pull. Regards Marcel
On Fri, 28 Jan 2022 23:30:14 +0100 Marcel Holtmann wrote: > > Thanks for fixing the warnings! :) > > > > I presume this is for the net-next given the name of your tree, but > > a lot of patches here have fixes tags. What's your methodology on > > separating fixes from new features? > > > > I think it may be worth adjusting the filter there and send more > > stuff earlier to Linus's tree. Especially fixes with the right mix > > of confidence and impact or pure device ID additions. > > > > To be clear - happy to pull this PR as is, I was meaning to ask about > > this for a while. > > we started to add Fixes: tag whenever you can identify a faulty commit or > can track down the original issue. This way we can later easily go back > and check. It have to note that a lot of vendor trees cherrypick patches > and this helps them picking the right ones. Thumbs up for that! > I reviewed the list of patches again, and frankly none of them are super > critical to go to Linus right away. My concern is that GregKH will start asking us why we hold onto trivial fixes like 5201d23cc8e5 until the merge window, I think this merge window has overflown his patch ID scheme ;) The risk of pushing fixes in early -rc's should be pretty low. But your call at the end of the day! > So if you don’t mind, please pull. Sure thing, done! :)
Hello: This pull request was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 28 Jan 2022 12:59:15 -0800 you wrote: > The following changes since commit 8aaaf2f3af2ae212428f4db1af34214225f5cec3: > > Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2022-01-09 17:00:17 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git tags/for-net-next-2022-01-28 > > [...] Here is the summary with links: - pull request: bluetooth 2022-01-28 https://git.kernel.org/netdev/net-next/c/0a78117213c4 You are awesome, thank you!
The following changes since commit 8aaaf2f3af2ae212428f4db1af34214225f5cec3: Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2022-01-09 17:00:17 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git tags/for-net-next-2022-01-28 for you to fetch changes up to 91cb4c19118a19470a9d7d6dbdf64763bbbadcde: Bluetooth: Increment management interface revision (2022-01-27 12:35:13 -0800) ---------------------------------------------------------------- bluetooth-next pull request for net-next: - Add support for RTL8822C hci_ver 0x08 - Add support for RTL8852AE part 0bda:2852 - Fix WBS setting for Intel legacy ROM products - Enable SCO over I2S ib mt7921s - Increment management interface revision ---------------------------------------------------------------- Dan Carpenter (1): Bluetooth: hci_sync: unlock on error in hci_inquiry_result_with_rssi_evt() Ismael Ferreras Morezuelas (1): Bluetooth: btusb: Whitespace fixes for btusb_setup_csr() Larry Finger (1): Bluetooth: btusb: Add one more Bluetooth part for the Realtek RTL8852AE Luiz Augusto von Dentz (4): Bluetooth: hci_sync: Fix compilation warning Bluetooth: hci_core: Rate limit the logging of invalid SCO handle Bluetooth: hci_event: Fix HCI_EV_VENDOR max_len Bluetooth: hci_sync: Fix queuing commands when HCI_UNREGISTER is set Manish Mandlik (2): Bluetooth: msft: Handle MSFT Monitor Device Event Bluetooth: mgmt: Add MGMT Adv Monitor Device Found/Lost events Marcel Holtmann (1): Bluetooth: Increment management interface revision Mark Chen (6): Bluetooth: mt7921s: Support wake on bluetooth Bluetooth: mt7921s: Enable SCO over I2S Bluetooth: mt7921s: fix firmware coredump retrieve Bluetooth: btmtksdio: refactor btmtksdio_runtime_[suspend|resume]() Bluetooth: mt7921s: fix bus hang with wrong privilege Bluetooth: mt7921s: fix btmtksdio_[drv|fw]_pmctrl() Pavel Skripkin (1): Bluetooth: hci_serdev: call init_rwsem() before p->open() Sean Wang (6): Bluetooth: btmtksdio: rename btsdio_mtk_reg_read Bluetooth: btmtksdio: move struct reg_read_cmd to common file Bluetooth: btmtksdio: clean up inconsistent error message in btmtksdio_mtk_reg_read Bluetooth: btmtksdio: lower log level in btmtksdio_runtime_[resume|suspend]() Bluetooth: btmtksdio: run sleep mode by default Bluetooth: btmtksdio: mask out interrupt status Soenke Huster (3): Bluetooth: fix null ptr deref on hci_sync_conn_complete_evt Bluetooth: msft: fix null pointer deref on msft_monitor_device_evt Bluetooth: hci_event: Ignore multiple conn complete events Tedd Ho-Jeong An (2): Bluetooth: btintel: Fix WBS setting for Intel legacy ROM products Bluetooth: Remove kernel-doc style comment block Vyacheslav Bocharov (2): Bluetooth: btrtl: Add support for RTL8822C hci_ver 0x08 Bluetooth: hci_h5: Add power reset via gpio in h5_btrtl_open drivers/bluetooth/btintel.c | 11 +- drivers/bluetooth/btintel.h | 1 + drivers/bluetooth/btmrvl_debugfs.c | 2 +- drivers/bluetooth/btmrvl_sdio.c | 2 +- drivers/bluetooth/btmtk.h | 35 +++++ drivers/bluetooth/btmtksdio.c | 276 +++++++++++++++++++++++++++++-------- drivers/bluetooth/btrtl.c | 8 ++ drivers/bluetooth/btusb.c | 14 +- drivers/bluetooth/hci_h5.c | 5 + drivers/bluetooth/hci_ll.c | 2 +- drivers/bluetooth/hci_serdev.c | 3 +- include/net/bluetooth/hci_core.h | 17 +++ include/net/bluetooth/mgmt.h | 16 +++ net/bluetooth/hci_conn.c | 1 + net/bluetooth/hci_core.c | 5 +- net/bluetooth/hci_event.c | 89 +++++++++--- net/bluetooth/hci_sync.c | 7 +- net/bluetooth/mgmt.c | 117 +++++++++++++++- net/bluetooth/msft.c | 170 +++++++++++++++++++++-- 19 files changed, 676 insertions(+), 105 deletions(-)