| Message ID | 20220201174256.1690515-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Bluetooth: hci_sync: fix undefined return of hci_disconnect_all_sync() | expand |
Hi Tom, On Tue, Feb 1, 2022 at 9:43 AM <trix@redhat.com> wrote: > > From: Tom Rix <trix@redhat.com> > > clang static analysis reports this problem > hci_sync.c:4428:2: warning: Undefined or garbage value > returned to caller > return err; > ^~~~~~~~~~ > > If there are no connections this function is a noop but > err is never set and a false error could be reported. > Return 0 as other hci_* functions do. > > Fixes: 182ee45da083 ("Bluetooth: hci_sync: Rework hci_suspend_notifier") > Signed-off-by: Tom Rix <trix@redhat.com> > --- > net/bluetooth/hci_sync.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c > index 6e71aa6b6feae..9327737da6003 100644 > --- a/net/bluetooth/hci_sync.c > +++ b/net/bluetooth/hci_sync.c > @@ -4425,7 +4425,7 @@ static int hci_disconnect_all_sync(struct hci_dev *hdev, u8 reason) > return err; > } > > - return err; > + return 0; > } > > /* This function perform power off HCI command sequence as follows: > -- > 2.26.3 Applied, thanks.
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 6e71aa6b6feae..9327737da6003 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -4425,7 +4425,7 @@ static int hci_disconnect_all_sync(struct hci_dev *hdev, u8 reason) return err; } - return err; + return 0; } /* This function perform power off HCI command sequence as follows: