diff mbox series

[net] gve: Recording rx queue before sending to napi

Message ID 20220207175901.2486596-1-jeroendb@google.com (mailing list archive)
State Accepted
Commit 084cbb2ec3af2d23be9de65fcc9493e21e265859
Delegated to: Netdev Maintainers
Headers show
Series [net] gve: Recording rx queue before sending to napi | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 5 blamed authors not CCed: sagis@google.com willemb@google.com csully@google.com lrizzo@google.com jonolson@google.com; 7 maintainers not CCed: sagis@google.com willemb@google.com csully@google.com lrizzo@google.com bcf@google.com awogbemila@google.com jonolson@google.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jeroen de Borst Feb. 7, 2022, 5:59 p.m. UTC 
From: Tao Liu <xliutaox@google.com>

This caused a significant performance degredation when using generic XDP
with multiple queues.

Fixes: f5cedc84a30d2 ("gve: Add transmit and receive support")
Signed-off-by: Tao Liu <xliutaox@google.com>
---
 drivers/net/ethernet/google/gve/gve_rx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 9, 2022, 5:20 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  7 Feb 2022 09:59:01 -0800 you wrote:
> From: Tao Liu <xliutaox@google.com>
> 
> This caused a significant performance degredation when using generic XDP
> with multiple queues.
> 
> Fixes: f5cedc84a30d2 ("gve: Add transmit and receive support")
> Signed-off-by: Tao Liu <xliutaox@google.com>
> 
> [...]

Here is the summary with links:
  - [net] gve: Recording rx queue before sending to napi
    https://git.kernel.org/netdev/net/c/084cbb2ec3af

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index 2068199445bd..e4e98aa7745f 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -609,6 +609,7 @@  static bool gve_rx(struct gve_rx_ring *rx, netdev_features_t feat,
 
 	*packet_size_bytes = skb->len + (skb->protocol ? ETH_HLEN : 0);
 	*work_done = work_cnt;
+	skb_record_rx_queue(skb, rx->q_num);
 	if (skb_is_nonlinear(skb))
 		napi_gro_frags(napi);
 	else