| Message ID | 20220212200343.921107-1-horatiu.vultur@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 867b1db874c93ceb86f9e10ef021e70c38cc4b4d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] net: lan966x: Fix when CONFIG_IPV6 is not set | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Sat, 12 Feb 2022 21:03:43 +0100 you wrote: > When CONFIG_IPV6 is not set, then the linking of the lan966x driver > fails with the following error: > > drivers/net/ethernet/microchip/lan966x/lan966x_main.c:444: undefined > reference to `ipv6_mc_check_mld' > > The fix consists in adding a check also for IS_ENABLED(CONFIG_IPV6) > > [...] Here is the summary with links: - [net-next,v2] net: lan966x: Fix when CONFIG_IPV6 is not set https://git.kernel.org/netdev/net-next/c/867b1db874c9 You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c index d62484f14564..4e877d9859bf 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c @@ -439,7 +439,8 @@ static bool lan966x_hw_offload(struct lan966x *lan966x, u32 port, ip_hdr(skb)->protocol == IPPROTO_IGMP) return false; - if (skb->protocol == htons(ETH_P_IPV6) && + if (IS_ENABLED(CONFIG_IPV6) && + skb->protocol == htons(ETH_P_IPV6) && ipv6_addr_is_multicast(&ipv6_hdr(skb)->daddr) && !ipv6_mc_check_mld(skb)) return false;
When CONFIG_IPV6 is not set, then the linking of the lan966x driver fails with the following error: drivers/net/ethernet/microchip/lan966x/lan966x_main.c:444: undefined reference to `ipv6_mc_check_mld' The fix consists in adding a check also for IS_ENABLED(CONFIG_IPV6) Fixes: 47aeea0d57e80c ("net: lan966x: Implement the callback SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- v1->v2: - use IS_ENABLED(CONFIG_IPV6) instead of #ifdef --- drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)