| Message ID | 20220215124042.186506-2-roberto.sassu@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf-lsm: Extend interoperability with IMA | expand |
| Context | Check | Description |
|---|---|---|
| bpf/vmtest-bpf-next-PR | fail | PR summary |
| bpf/vmtest-bpf-next | fail | VM_Test |
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply, async |
On 2/15/22 5:40 AM, Roberto Sassu wrote: > Fix some warnings in ima_main.c, displayed with W=n make argument. > Thank you for fixing these. Doc builds are full of them and few less is welcome. Adding the warns or summary of them to change log will be good. > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > --- > security/integrity/ima/ima_main.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c > index 8c6e4514d494..946ba8a12eab 100644 > --- a/security/integrity/ima/ima_main.c > +++ b/security/integrity/ima/ima_main.c > @@ -418,6 +418,7 @@ int ima_file_mmap(struct file *file, unsigned long prot) > > /** > * ima_file_mprotect - based on policy, limit mprotect change > + * @vma: vm_area_struct protection is set to > * @prot: contains the protection that will be applied by the kernel. > * Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
> From: Shuah Khan [mailto:skhan@linuxfoundation.org] > Sent: Tuesday, February 15, 2022 4:46 PM > On 2/15/22 5:40 AM, Roberto Sassu wrote: > > Fix some warnings in ima_main.c, displayed with W=n make argument. > > > > Thank you for fixing these. Doc builds are full of them and few less > is welcome. > > Adding the warns or summary of them to change log will be good. Hi Shuah ok, I will add a brief description of what I fixed in the next version of the patch set. Thanks Roberto HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Zhong Ronghua > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > > --- > > security/integrity/ima/ima_main.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/security/integrity/ima/ima_main.c > b/security/integrity/ima/ima_main.c > > index 8c6e4514d494..946ba8a12eab 100644 > > --- a/security/integrity/ima/ima_main.c > > +++ b/security/integrity/ima/ima_main.c > > @@ -418,6 +418,7 @@ int ima_file_mmap(struct file *file, unsigned long prot) > > > > /** > > * ima_file_mprotect - based on policy, limit mprotect change > > + * @vma: vm_area_struct protection is set to > > * @prot: contains the protection that will be applied by the kernel. > > * > > > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> > > thanks, > -- Shuah
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index 8c6e4514d494..946ba8a12eab 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -418,6 +418,7 @@ int ima_file_mmap(struct file *file, unsigned long prot) /** * ima_file_mprotect - based on policy, limit mprotect change + * @vma: vm_area_struct protection is set to * @prot: contains the protection that will be applied by the kernel. * * Files can be mmap'ed read/write and later changed to execute to circumvent @@ -610,8 +611,8 @@ EXPORT_SYMBOL_GPL(ima_inode_hash); /** * ima_post_create_tmpfile - mark newly created tmpfile as new - * @mnt_userns: user namespace of the mount the inode was found from - * @file : newly created tmpfile + * @mnt_userns: user namespace of the mount the inode was found from + * @inode: inode of the newly created tmpfile * * No measuring, appraising or auditing of newly created tmpfiles is needed. * Skip calling process_measurement(), but indicate which newly, created @@ -643,7 +644,7 @@ void ima_post_create_tmpfile(struct user_namespace *mnt_userns, /** * ima_post_path_mknod - mark as a new inode - * @mnt_userns: user namespace of the mount the inode was found from + * @mnt_userns: user namespace of the mount the inode was found from * @dentry: newly created dentry * * Mark files created via the mknodat syscall as new, so that the @@ -814,8 +815,8 @@ int ima_load_data(enum kernel_load_data_id id, bool contents) * ima_post_load_data - appraise decision based on policy * @buf: pointer to in memory file contents * @size: size of in memory file contents - * @id: kernel load data caller identifier - * @description: @id-specific description of contents + * @load_id: kernel load data caller identifier + * @description: @load_id-specific description of contents * * Measure/appraise/audit in memory buffer based on policy. Policy rules * are written in terms of a policy identifier.
Fix some warnings in ima_main.c, displayed with W=n make argument. Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> --- security/integrity/ima/ima_main.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)