| Message ID | 20220228091646.3059-1-paulb@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v3,1/1] net/sched: act_ct: Fix flow table lookup failure with no originating ifindex | expand |
Sent old v2 by mistake, please ignore, resending actual v3 as v4. Thanks, Paul.
diff --git a/include/net/netfilter/nf_flow_table.h b/include/net/netfilter/nf_flow_table.h index a3647fadf1cc..61dc5e833557 100644 --- a/include/net/netfilter/nf_flow_table.h +++ b/include/net/netfilter/nf_flow_table.h @@ -114,8 +114,6 @@ struct flow_offload_tuple { __be16 dst_port; }; - int iifidx; - u8 l3proto; u8 l4proto; struct { @@ -126,6 +124,7 @@ struct flow_offload_tuple { /* All members above are keys for lookups, see flow_offload_hash(). */ struct { } __hash; + int iifidx; u8 dir:2, xmit_type:2, encap_num:2, diff --git a/net/netfilter/nf_flow_table_core.c b/net/netfilter/nf_flow_table_core.c index b90eca7a2f22..01d32f08a1fd 100644 --- a/net/netfilter/nf_flow_table_core.c +++ b/net/netfilter/nf_flow_table_core.c @@ -257,6 +257,9 @@ static int flow_offload_hash_cmp(struct rhashtable_compare_arg *arg, const struct flow_offload_tuple *tuple = arg->key; const struct flow_offload_tuple_rhash *x = ptr; + if (tuple->iifidx && tuple->iifidx != x->tuple.iifidx) + return 1; + if (memcmp(&x->tuple, tuple, offsetof(struct flow_offload_tuple, __hash))) return 1;
After cited commit optimizted hw insertion, flow table entries are populated with ifindex information which was intended to only be used for HW offload. This tuple ifindex is hashed in the flow table key, so it must be filled for lookup to be successful. But tuple ifindex is only relevant for the netfilter flowtables (nft), so it's not filled in act_ct flow table lookup, resulting in lookup failure, and no SW offload and no offload teardown for TCP connection FIN/RST packets. To fix this, remove ifindex from hash, and allow lookup without the ifindex. Act ct will lookup without the ifindex filled. Fixes: 9795ded7f924 ("net/sched: act_ct: Fill offloading tuple iifidx") Signed-off-by: Paul Blakey <paulb@nvidia.com> --- Changelog: v2->v3: As suggested by pablo, moved tc specific hardware offload related ifindex to a tc specific field, so wont be part of hash/lookup. v1->v2: Replaced flag withdx being zero at lookup(). Fixed commit msg Fixes header subject include/net/netfilter/nf_flow_table.h | 3 +-- net/netfilter/nf_flow_table_core.c | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-)