| Message ID | 20220309034032.405212-2-dmichail@fungible.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77f09e66f613e4801134c64d26a0be593588a42e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/fungible: fix errors when CONFIG_TLS_DEVICE=n | expand |
On Tue, 8 Mar 2022 19:40:31 -0800 Dimitris Michailidis wrote: > Having the definitions of {__,}tls_driver_ctx() under an #if > guard means code referencing them also needs to rely on the > preprocessor. The protection doesn't appear needed so make the > definitions unconditional. > > Fixes: db37bc177dae ("net/funeth: add the data path") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Dimitris Michailidis <dmichail@fungible.com> Acked-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/include/net/tls.h b/include/net/tls.h index 526cb2c3b724..b6968a5b5538 100644 --- a/include/net/tls.h +++ b/include/net/tls.h @@ -626,7 +626,6 @@ tls_offload_ctx_rx(const struct tls_context *tls_ctx) return (struct tls_offload_context_rx *)tls_ctx->priv_ctx_rx; } -#if IS_ENABLED(CONFIG_TLS_DEVICE) static inline void *__tls_driver_ctx(struct tls_context *tls_ctx, enum tls_offload_ctx_dir direction) { @@ -641,7 +640,6 @@ tls_driver_ctx(const struct sock *sk, enum tls_offload_ctx_dir direction) { return __tls_driver_ctx(tls_get_ctx(sk), direction); } -#endif #define RESYNC_REQ BIT(0) #define RESYNC_REQ_ASYNC BIT(1)
Having the definitions of {__,}tls_driver_ctx() under an #if guard means code referencing them also needs to rely on the preprocessor. The protection doesn't appear needed so make the definitions unconditional. Fixes: db37bc177dae ("net/funeth: add the data path") Reported-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Dimitris Michailidis <dmichail@fungible.com> --- include/net/tls.h | 2 -- 1 file changed, 2 deletions(-)