| Message ID | 20220310073505.49990-1-kurt@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f65e58440d4fca277233ebef78f402a0dbd02da5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] flow_dissector: Add support for HSRv0 | expand |
On Thu, Mar 10, 2022 at 08:35:05AM +0100, Kurt Kanzenbach wrote: > Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for > HSR within the flow dissector. However, it only works for HSR in version > 1. Version 0 uses a different Ether Type. Add support for it. > > Reported-by: Anthony Harivel <anthony.harivel@linutronix.de> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> This observation came up as a result of the fact that HSRv0 is still in actual use, or just for correctness' sake? > --- > net/core/flow_dissector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c > index 34441a32e3be..03b6e649c428 100644 > --- a/net/core/flow_dissector.c > +++ b/net/core/flow_dissector.c > @@ -1283,6 +1283,7 @@ bool __skb_flow_dissect(const struct net *net, > break; > } > > + case htons(ETH_P_PRP): > case htons(ETH_P_HSR): { > struct hsr_tag *hdr, _hdr; > > -- > 2.30.2 >
On Thu Mar 10 2022, Vladimir Oltean wrote: > On Thu, Mar 10, 2022 at 08:35:05AM +0100, Kurt Kanzenbach wrote: >> Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for >> HSR within the flow dissector. However, it only works for HSR in version >> 1. Version 0 uses a different Ether Type. Add support for it. >> >> Reported-by: Anthony Harivel <anthony.harivel@linutronix.de> >> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> > > This observation came up as a result of the fact that HSRv0 is still in > actual use, or just for correctness' sake? It came up while testing the Linux HSR implementation. Thanks, Kurt
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 10 Mar 2022 08:35:05 +0100 you wrote: > Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for > HSR within the flow dissector. However, it only works for HSR in version > 1. Version 0 uses a different Ether Type. Add support for it. > > Reported-by: Anthony Harivel <anthony.harivel@linutronix.de> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> > > [...] Here is the summary with links: - [net-next] flow_dissector: Add support for HSRv0 https://git.kernel.org/netdev/net-next/c/f65e58440d4f You are awesome, thank you!
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 34441a32e3be..03b6e649c428 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -1283,6 +1283,7 @@ bool __skb_flow_dissect(const struct net *net, break; } + case htons(ETH_P_PRP): case htons(ETH_P_HSR): { struct hsr_tag *hdr, _hdr;
Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for HSR within the flow dissector. However, it only works for HSR in version 1. Version 0 uses a different Ether Type. Add support for it. Reported-by: Anthony Harivel <anthony.harivel@linutronix.de> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- net/core/flow_dissector.c | 1 + 1 file changed, 1 insertion(+)