| Message ID | 20220316165347.599154-1-jonathan.lemon@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2b341f7532d4f6c8b84206daad202a745962b844 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ptp: ocp: Make debugfs variables the correct bitwidth | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 16 Mar 2022 09:53:47 -0700 you wrote: > An earlier patch mistakenly changed these variables from u32 to u16, > leading to unintended truncation. Restore the original logic. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> > --- > drivers/ptp/ptp_ocp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next] ptp: ocp: Make debugfs variables the correct bitwidth https://git.kernel.org/netdev/net-next/c/2b341f7532d4 You are awesome, thank you!
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index d8cefc89a588..d64a1ce5f5bc 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -2983,11 +2983,12 @@ ptp_ocp_summary_show(struct seq_file *s, void *data) { struct device *dev = s->private; struct ptp_system_timestamp sts; - u16 sma_val[4][2], ctrl, val; struct ts_reg __iomem *ts_reg; struct timespec64 ts; struct ptp_ocp *bp; + u16 sma_val[4][2]; char *src, *buf; + u32 ctrl, val; bool on, map; int i;
An earlier patch mistakenly changed these variables from u32 to u16, leading to unintended truncation. Restore the original logic. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> --- drivers/ptp/ptp_ocp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)