| Message ID | 20220318012035.89482-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 79fdce0513aceff7666e2e4dfa8fc28ea381d3a7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | qlcnic: remove redundant assignment to variable index | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 18 Mar 2022 01:20:35 +0000 you wrote: > Variable index is being assigned a value that is never read, it is being > re-assigned later in a following for-loop. The assignment is redundant > and can be removed. > > Cleans up clang scan build warning: > drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c:1358:17: warning: > Although the value stored to 'index' is used in the enclosing expression, > the value is never actually read from 'index' [deadcode.DeadStores] > > [...] Here is the summary with links: - qlcnic: remove redundant assignment to variable index https://git.kernel.org/netdev/net-next/c/79fdce0513ac You are awesome, thank you!
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index e10fe071a40f..54a2d653be63 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1355,7 +1355,7 @@ static void qlcnic_get_ethtool_stats(struct net_device *dev, memset(data, 0, stats->n_stats * sizeof(u64)); - for (ring = 0, index = 0; ring < adapter->drv_tx_rings; ring++) { + for (ring = 0; ring < adapter->drv_tx_rings; ring++) { if (adapter->is_up == QLCNIC_ADAPTER_UP_MAGIC) { tx_ring = &adapter->tx_ring[ring]; data = qlcnic_fill_tx_queue_stats(data, tx_ring);
Variable index is being assigned a value that is never read, it is being re-assigned later in a following for-loop. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c:1358:17: warning: Although the value stored to 'index' is used in the enclosing expression, the value is never actually read from 'index' [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)