| Message ID | 20220321095648.4760-2-dylan_hung@aspeedtech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add reset deassertion for Aspeed MDIO | expand |
On Mon, Mar 21, 2022 at 05:56:46PM +0800, Dylan Hung wrote: > The AST2600 MDIO bus controller has a reset control bit and must be > deasserted before the manipulating the MDIO controller. > > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > Cc: stable@vger.kernel.org Please read the netdev FAQ. You need to indicates which networking tree this is for in the Subject line, and you need to make use of the correct git tree. You should also have a Fixes: tag, indicating where the issue was introduced. Andrew
On Mon, 21 Mar 2022 17:56:46 +0800, Dylan Hung wrote: > The AST2600 MDIO bus controller has a reset control bit and must be > deasserted before the manipulating the MDIO controller. > > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > Cc: stable@vger.kernel.org > --- > .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1607671 mdio@1e650000: 'resets' is a required property arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dt.yaml mdio@1e650008: 'resets' is a required property arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dt.yaml arch/arm/boot/dts/aspeed-bmc-facebook-fuji.dt.yaml mdio@1e650010: 'resets' is a required property arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml mdio@1e650018: 'resets' is a required property arch/arm/boot/dts/aspeed-ast2600-evb-a1.dt.yaml arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml arch/arm/boot/dts/aspeed-bmc-facebook-cloudripper.dt.yaml
On 21/03/2022 10:56, Dylan Hung wrote: > The AST2600 MDIO bus controller has a reset control bit and must be > deasserted before the manipulating the MDIO controller. > > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > Cc: stable@vger.kernel.org No bugs fixes, no cc-stable. Especially that you break existing devices... > --- > .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > index 1c88820cbcdf..8ba108e25d94 100644 > --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > @@ -23,12 +23,15 @@ properties: > reg: > maxItems: 1 > description: The register range of the MDIO controller instance Missing empty line. > + resets: > + maxItems: 1 > > required: > - compatible > - reg > - "#address-cells" > - "#size-cells" > + - resets You break the ABI. This isusually not accepted in a regular kernel and even totally not accepted accepted for stable kernel. > > unevaluatedProperties: false > > @@ -39,6 +42,7 @@ examples: > reg = <0x1e650000 0x8>; > #address-cells = <1>; > #size-cells = <0>; > + resets = <&syscon 35>; > > ethphy0: ethernet-phy@0 { > compatible = "ethernet-phy-ieee802.3-c22"; Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml index 1c88820cbcdf..8ba108e25d94 100644 --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml @@ -23,12 +23,15 @@ properties: reg: maxItems: 1 description: The register range of the MDIO controller instance + resets: + maxItems: 1 required: - compatible - reg - "#address-cells" - "#size-cells" + - resets unevaluatedProperties: false @@ -39,6 +42,7 @@ examples: reg = <0x1e650000 0x8>; #address-cells = <1>; #size-cells = <0>; + resets = <&syscon 35>; ethphy0: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22";
The AST2600 MDIO bus controller has a reset control bit and must be deasserted before the manipulating the MDIO controller. Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> Cc: stable@vger.kernel.org --- .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 ++++ 1 file changed, 4 insertions(+)