| Message ID | 20220401054244.18131-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c3efcedd272aa6dd5929e20cf902a52ddaa1197a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: micrel: fix KS8851_MLL Kconfig | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 31 Mar 2022 22:42:44 -0700 you wrote: > KS8851_MLL selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, > so make KS8851_MLL also depend on PTP_1588_CLOCK_OPTIONAL since > 'select' does not follow any dependency chains. > > Fixes kconfig warning and build errors: > > WARNING: unmet direct dependencies detected for MICREL_PHY > Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m] > Selected by [y]: > - KS8851_MLL [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && HAS_IOMEM [=y] > > [...] Here is the summary with links: - net: micrel: fix KS8851_MLL Kconfig https://git.kernel.org/netdev/net/c/c3efcedd272a You are awesome, thank you!
--- mmotm-2022-0331-2037.orig/drivers/net/ethernet/micrel/Kconfig +++ mmotm-2022-0331-2037/drivers/net/ethernet/micrel/Kconfig @@ -39,6 +39,7 @@ config KS8851 config KS8851_MLL tristate "Micrel KS8851 MLL" depends on HAS_IOMEM + depends on PTP_1588_CLOCK_OPTIONAL select MII select CRC32 select EEPROM_93CX6
KS8851_MLL selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, so make KS8851_MLL also depend on PTP_1588_CLOCK_OPTIONAL since 'select' does not follow any dependency chains. Fixes kconfig warning and build errors: WARNING: unmet direct dependencies detected for MICREL_PHY Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m] Selected by [y]: - KS8851_MLL [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && HAS_IOMEM [=y] ld: drivers/net/phy/micrel.o: in function `lan8814_ts_info': micrel.c:(.text+0xb35): undefined reference to `ptp_clock_index' ld: drivers/net/phy/micrel.o: in function `lan8814_probe': micrel.c:(.text+0x2586): undefined reference to `ptp_clock_register' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> --- drivers/net/ethernet/micrel/Kconfig | 1 + 1 file changed, 1 insertion(+)