| Message ID | 20220405065936.4105272-1-horatiu.vultur@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d7e4fd72bb9be080c23a099b0dff1007109fc2b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: micrel: Fix KS8851 Kconfig | expand |
On 4/4/22 23:59, Horatiu Vultur wrote: > KS8851 selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, so > make KS8851 also depend on PTP_1588_CLOCK_OPTIONAL. > > Fixes kconfig warning and build errors: > > WARNING: unmet direct dependencies detected for MICREL_PHY > Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m] > Selected by [y]: > - KS8851 [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && SPI [=y] > > ld.lld: error: undefined symbol: ptp_clock_register referenced by micrel.c > net/phy/micrel.o:(lan8814_probe) in archive drivers/built-in.a > ld.lld: error: undefined symbol: ptp_clock_index referenced by micrel.c > net/phy/micrel.o:(lan8814_ts_info) in archive drivers/built-in.a > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy") > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> Tested-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > drivers/net/ethernet/micrel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/micrel/Kconfig b/drivers/net/ethernet/micrel/Kconfig > index 1b632cdd7630..830363bafcce 100644 > --- a/drivers/net/ethernet/micrel/Kconfig > +++ b/drivers/net/ethernet/micrel/Kconfig > @@ -28,6 +28,7 @@ config KS8842 > config KS8851 > tristate "Micrel KS8851 SPI" > depends on SPI > + depends on PTP_1588_CLOCK_OPTIONAL > select MII > select CRC32 > select EEPROM_93CX6
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 5 Apr 2022 08:59:36 +0200 you wrote: > KS8851 selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, so > make KS8851 also depend on PTP_1588_CLOCK_OPTIONAL. > > Fixes kconfig warning and build errors: > > WARNING: unmet direct dependencies detected for MICREL_PHY > Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m] > Selected by [y]: > - KS8851 [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && SPI [=y] > > [...] Here is the summary with links: - [net] net: micrel: Fix KS8851 Kconfig https://git.kernel.org/netdev/net/c/1d7e4fd72bb9 You are awesome, thank you!
diff --git a/drivers/net/ethernet/micrel/Kconfig b/drivers/net/ethernet/micrel/Kconfig index 1b632cdd7630..830363bafcce 100644 --- a/drivers/net/ethernet/micrel/Kconfig +++ b/drivers/net/ethernet/micrel/Kconfig @@ -28,6 +28,7 @@ config KS8842 config KS8851 tristate "Micrel KS8851 SPI" depends on SPI + depends on PTP_1588_CLOCK_OPTIONAL select MII select CRC32 select EEPROM_93CX6
KS8851 selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, so make KS8851 also depend on PTP_1588_CLOCK_OPTIONAL. Fixes kconfig warning and build errors: WARNING: unmet direct dependencies detected for MICREL_PHY Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m] Selected by [y]: - KS8851 [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && SPI [=y] ld.lld: error: undefined symbol: ptp_clock_register referenced by micrel.c net/phy/micrel.o:(lan8814_probe) in archive drivers/built-in.a ld.lld: error: undefined symbol: ptp_clock_index referenced by micrel.c net/phy/micrel.o:(lan8814_ts_info) in archive drivers/built-in.a Reported-by: kernel test robot <lkp@intel.com> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy") Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- drivers/net/ethernet/micrel/Kconfig | 1 + 1 file changed, 1 insertion(+)