| Message ID | 20220415023957.1117879-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0a03f3c511f57da4d7159a150f1ab4b87f62c040 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] octeon_ep: fix error return code in octep_probe() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 15 Apr 2022 10:39:57 +0800 you wrote: > If register_netdev() fails , it should return error > code in octep_probe(). > > Fixes: 862cd659a6fb ("octeon_ep: Add driver framework and device initialization") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > > [...] Here is the summary with links: - [-next] octeon_ep: fix error return code in octep_probe() https://git.kernel.org/netdev/net-next/c/0a03f3c511f5 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 5d39c857ea41..f2af5ebffcf1 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -1071,7 +1071,8 @@ static int octep_probe(struct pci_dev *pdev, const struct pci_device_id *ent) octep_get_mac_addr(octep_dev, octep_dev->mac_addr); eth_hw_addr_set(netdev, octep_dev->mac_addr); - if (register_netdev(netdev)) { + err = register_netdev(netdev); + if (err) { dev_err(&pdev->dev, "Failed to register netdev\n"); goto register_dev_err; }
If register_netdev() fails , it should return error code in octep_probe(). Fixes: 862cd659a6fb ("octeon_ep: Add driver framework and device initialization") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)