| Message ID | 20220422061431.1905579-1-yajun.deng@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b0e653b2a0d99299a9fce1c1ca4393f3173620d4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] arp: fix unused variable warnning when CONFIG_PROC_FS=n | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 22 Apr 2022 14:14:31 +0800 you wrote: > net/ipv4/arp.c:1412:36: warning: unused variable 'arp_seq_ops' [-Wunused-const-variable] > > Add #ifdef CONFIG_PROC_FS for 'arp_seq_ops'. > > Fixes: e968b1b3e9b8 ("arp: Remove #ifdef CONFIG_PROC_FS") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Yajun Deng <yajun.deng@linux.dev> > > [...] Here is the summary with links: - [net-next] arp: fix unused variable warnning when CONFIG_PROC_FS=n https://git.kernel.org/netdev/net-next/c/b0e653b2a0d9 You are awesome, thank you!
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 2d0c05ca9c6f..ab4a5601c82a 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -1304,9 +1304,9 @@ static struct packet_type arp_packet_type __read_mostly = { .func = arp_rcv, }; +#ifdef CONFIG_PROC_FS #if IS_ENABLED(CONFIG_AX25) -/* ------------------------------------------------------------------------ */ /* * ax25 -> ASCII conversion */ @@ -1412,16 +1412,13 @@ static void *arp_seq_start(struct seq_file *seq, loff_t *pos) return neigh_seq_start(seq, pos, &arp_tbl, NEIGH_SEQ_SKIP_NOARP); } -/* ------------------------------------------------------------------------ */ - static const struct seq_operations arp_seq_ops = { .start = arp_seq_start, .next = neigh_seq_next, .stop = neigh_seq_stop, .show = arp_seq_show, }; - -/* ------------------------------------------------------------------------ */ +#endif /* CONFIG_PROC_FS */ static int __net_init arp_net_init(struct net *net) {
net/ipv4/arp.c:1412:36: warning: unused variable 'arp_seq_ops' [-Wunused-const-variable] Add #ifdef CONFIG_PROC_FS for 'arp_seq_ops'. Fixes: e968b1b3e9b8 ("arp: Remove #ifdef CONFIG_PROC_FS") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Yajun Deng <yajun.deng@linux.dev> --- net/ipv4/arp.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)