| Message ID | 20220428095317.538829-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a9e9b091a1c14ecd8bd9d3214a62142a1786fe30 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: mt7530: add missing of_node_put() in mt7530_setup() | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 28 Apr 2022 17:53:17 +0800 you wrote: > Add of_node_put() if of_get_phy_mode() fails in mt7530_setup() > > Fixes: 0c65b2b90d13 ("net: of_get_phy_mode: Change API to solve int/unit warnings") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/dsa/mt7530.c | 1 + > 1 file changed, 1 insertion(+) Here is the summary with links: - net: dsa: mt7530: add missing of_node_put() in mt7530_setup() https://git.kernel.org/netdev/net/c/a9e9b091a1c1 You are awesome, thank you!
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 19f0035d4410..fe3cb26f4287 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2229,6 +2229,7 @@ mt7530_setup(struct dsa_switch *ds) ret = of_get_phy_mode(mac_np, &interface); if (ret && ret != -ENODEV) { of_node_put(mac_np); + of_node_put(phy_node); return ret; } id = of_mdio_parse_addr(ds->dev, phy_node);
Add of_node_put() if of_get_phy_mode() fails in mt7530_setup() Fixes: 0c65b2b90d13 ("net: of_get_phy_mode: Change API to solve int/unit warnings") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/mt7530.c | 1 + 1 file changed, 1 insertion(+)