| Message ID | 20220430232327.4091825-2-colin.foster@in-advantage.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 05e4ed1ce585637958c8ad6121999dc3109633ad |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ocelot stats improvement | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 24 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Sat, Apr 30, 2022 at 04:23:26PM -0700, Colin Foster wrote: > Commit 2f187bfa6f35 ("net: ethernet: ocelot: remove the need for num_stats > initializer") added a flags field to the ocelot stats structure. The same > behavior can be achieved without this additional field taking up extra > memory. > > Remove this structure element to free up RAM > > Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h index 5c4f57cfa785..75739766244b 100644 --- a/include/soc/mscc/ocelot.h +++ b/include/soc/mscc/ocelot.h @@ -105,11 +105,9 @@ #define REG_RESERVED_ADDR 0xffffffff #define REG_RESERVED(reg) REG(reg, REG_RESERVED_ADDR) -#define OCELOT_STAT_FLAG_END BIT(0) - #define for_each_stat(ocelot, stat) \ for ((stat) = ocelot->stats_layout; \ - !((stat)->flags & OCELOT_STAT_FLAG_END); \ + ((stat)->name[0] != '\0'); \ (stat)++) enum ocelot_target { @@ -542,11 +540,10 @@ enum ocelot_ptp_pins { struct ocelot_stat_layout { u32 offset; - u32 flags; char name[ETH_GSTRING_LEN]; }; -#define OCELOT_STAT_END { .flags = OCELOT_STAT_FLAG_END } +#define OCELOT_STAT_END { .name = "" } struct ocelot_stats_region { struct list_head node;
Commit 2f187bfa6f35 ("net: ethernet: ocelot: remove the need for num_stats initializer") added a flags field to the ocelot stats structure. The same behavior can be achieved without this additional field taking up extra memory. Remove this structure element to free up RAM Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: Colin Foster <colin.foster@in-advantage.com> --- include/soc/mscc/ocelot.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)