| Message ID | 20220504090739.21821-3-nicolas.dichtel@6wind.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e71b7f1f44d3d88c677769c85ef0171caf9fc89f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | vrf: fix address binding with icmp socket | expand |
On 5/4/22 2:07 AM, Nicolas Dichtel wrote: > The 'ping' utility is able to manage two kind of sockets (raw or icmp), > depending on the sysctl ping_group_range. By default, ping_group_range is > set to '1 0', which forces ping to use an ip raw socket. > > Let's replay the ping tests by allowing 'ping' to use the ip icmp socket. > After the previous patch, ipv4 tests results are the same with both kinds > of socket. For ipv6, there are a lot a new failures (the previous patch I'll take a look at those when I get a few minutes. > fixes only two cases). > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- > tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Reviewed-by: David Ahern <dsahern@kernel.org>
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh index 47c4d4b4a44a..54701c8b0cd7 100755 --- a/tools/testing/selftests/net/fcnal-test.sh +++ b/tools/testing/selftests/net/fcnal-test.sh @@ -810,10 +810,16 @@ ipv4_ping() setup set_sysctl net.ipv4.raw_l3mdev_accept=1 2>/dev/null ipv4_ping_novrf + setup + set_sysctl net.ipv4.ping_group_range='0 2147483647' 2>/dev/null + ipv4_ping_novrf log_subsection "With VRF" setup "yes" ipv4_ping_vrf + setup "yes" + set_sysctl net.ipv4.ping_group_range='0 2147483647' 2>/dev/null + ipv4_ping_vrf } ################################################################################ @@ -2348,10 +2354,16 @@ ipv6_ping() log_subsection "No VRF" setup ipv6_ping_novrf + setup + set_sysctl net.ipv4.ping_group_range='0 2147483647' 2>/dev/null + ipv6_ping_novrf log_subsection "With VRF" setup "yes" ipv6_ping_vrf + setup "yes" + set_sysctl net.ipv4.ping_group_range='0 2147483647' 2>/dev/null + ipv6_ping_vrf } ################################################################################
The 'ping' utility is able to manage two kind of sockets (raw or icmp), depending on the sysctl ping_group_range. By default, ping_group_range is set to '1 0', which forces ping to use an ip raw socket. Let's replay the ping tests by allowing 'ping' to use the ip icmp socket. After the previous patch, ipv4 tests results are the same with both kinds of socket. For ipv6, there are a lot a new failures (the previous patch fixes only two cases). Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- tools/testing/selftests/net/fcnal-test.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+)