| Message ID | 20220505021833.3864434-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: dpaa2-mac: add missing of_node_put() in dpaa2_mac_get_node() | expand |
On Thu, 5 May 2022 10:18:33 +0800 Yang Yingliang wrote: > Add missing of_node_put() in error path in dpaa2_mac_get_node(). > > Fixes: 5b1e38c0792c ("dpaa2-mac: bail if the dpmacs fwnode is not found") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > index c48811d3bcd5..fab2ce6bee9f 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c > @@ -108,8 +108,10 @@ static struct fwnode_handle *dpaa2_mac_get_node(struct device *dev, > return ERR_PTR(-EPROBE_DEFER); > } > > - if (!parent) > + if (!parent) { > + of_node_put(dpmacs); I don't see how !parent && dpmacs can ever be true. > return NULL; > + } > > fwnode_for_each_child_node(parent, child) { > err = -EINVAL;
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c index c48811d3bcd5..fab2ce6bee9f 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c @@ -108,8 +108,10 @@ static struct fwnode_handle *dpaa2_mac_get_node(struct device *dev, return ERR_PTR(-EPROBE_DEFER); } - if (!parent) + if (!parent) { + of_node_put(dpmacs); return NULL; + } fwnode_for_each_child_node(parent, child) { err = -EINVAL;
Add missing of_node_put() in error path in dpaa2_mac_get_node(). Fixes: 5b1e38c0792c ("dpaa2-mac: bail if the dpmacs fwnode is not found") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)